Events, updateComplete Fires early

[TheSin-]

I seems that updateComplete fires before pager+ajax is done.

This isn't totally wrong, technically, I was hoping for something like

updateComplete->ajaxStart->ajaxEnd

or

updateComplete->ajaxStart->updateComplete

I added an ajaxStart trigger on line 311 of query.tablesorter.pager.js

                                tc.$table.trigger('ajaxStart');
                                $.ajax(c.ajaxObject);

which is working, but it does

ajaxStart->updateComplete (but it's not complete, the table isn't done rendering)

Maybe updateComplete needs to be later? or maybe we need a renderComplete?

[Mottie]

I can do a little reworking, but let me ask this first... if I made updateComplete fire at the same time as pagerChange (line 283), would that work for you? I see this sequence now: ajaxStart -> pagerChange -> updateComplete

if (p.initialized) {
    $t.trigger('pagerChange', p);
    $t.trigger('updateComplete');
}

I also made this change to the core:

function resortComplete($table, callback){
    var c = $table[0].config;
    if (c.pager && !c.pager.ajax) {
        $table.trigger('updateComplete');
    }
    if (typeof callback === "function") {
        callback($table[0]);
    }
}

[TheSin-]

I'll have to find that again in my code, see how I fixed it. I just assumed updateComplete was the very last trigger, after addons etc etc, so that I could run row calculations and sure from that trigger.

[Mottie]

It is the last event, when ajax isn't being used 🙀

[TheSin-]

do we need an ajaxComplete? I suppose I could just attach tot he jquery ajax event but I think keeping things in the tablesorter config would be better. Maybe in tablesorter ajax call we could add a .onComplete to the ajax call that fires ajaxComplete or something? How does that sound?

[Mottie]

Well, I don't really want to complicate things more... I think I can make it work so that updateComplete is fired when ajax is complete. That way you don't need to bind to different events.

[TheSin-]

that works for me, I'm happy to kepe the same trigger, and honestly that makes the most sense. Specially if you have a fix for it.

[Mottie]

Cool, but is it working for you? It seems to be working properly for me, but I haven't extensively tested it yet.

[TheSin-]

still trying to find the example that was not working for me so I can test ;) My project is very large and I use tablesorter extensively throughout it ;) As soon as I find the page I'll report back.

[Mottie]

Hey @TheSin-!

Any news on this? I'm getting closer to finishing up the next update and hoping that this fix worked. :P

[TheSin-]

sorry I'm not forgetting or ignoring just been sooooo busy as of late. I'll seriously try and test this tomorrow to be sure, but I do believe just looking at the code that it will work.

[Mottie]

crosses fingers

[TheSin-]

I'm feeling good about it, and you are a beast today!!! I can't wait to test to new release!!

[Mottie]

And all without a caffeine boost! ;P

[TheSin-]

damn it man someone get this man a caffeine drip stat!!!!