Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

addVolumesToHierarchy is too specific #308

Open
bcdarwin opened this issue Apr 29, 2022 · 2 comments
Open

addVolumesToHierarchy is too specific #308

bcdarwin opened this issue Apr 29, 2022 · 2 comments

Comments

@bcdarwin
Copy link
Member

It can only accumulate by sum rather than mean, volume-weighted mean, etc. (in which case it's ambiguous whether it should be renamed...).

@bcdarwin
Copy link
Member Author

From the documentation:

Currently propagates volumes up the tree by summing. Future versions will add propagating through weighted means or other functions

@bcdarwin
Copy link
Member Author

Maybe something like addObservationsToLeaves <- function (hdefs, obs_matrix, colname) { ...error checking and assigning observations into leaves as in addHierarchyToVolumes...} is sufficient, or addObservationsToHierarchy also accepting combining functions. We would then generalize hanatLm via optional colname = "volumes" argument.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant