Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update HTTP to HTTPS #2218

Closed
ghost opened this issue Nov 18, 2018 · 3 comments
Closed

Update HTTP to HTTPS #2218

ghost opened this issue Nov 18, 2018 · 3 comments

Comments

@ghost
Copy link

ghost commented Nov 18, 2018

Changed links to HTTPS when supported.
Pull request:
#2219

Please review the pull request.

@ghost ghost mentioned this issue Nov 18, 2018
@Pomax
Copy link
Contributor

Pomax commented Nov 19, 2018

Thank you for the PR, but I would like to know why you filed it. Most of the changes in your PR are to text/comments rather than active code, and so aren't a problem that requires fixing. The only active code change is to the by-convention inactive domain "example.com" so whether that points to http or https (or even ftp or mailto, etc) doesn't make a difference.

@ghost
Copy link
Author

ghost commented Nov 19, 2018

@Pomax Think of it more as an enhancement then anything else. The more we use https, even in comments, the better.

@Pomax
Copy link
Contributor

Pomax commented Nov 21, 2018

fair, I mostly wanted to see if you were a bot or a real human. Had you been a bot, there definitely wouldn't have been a response as intelligent as yours =)

Merged, thanks for the fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant