Skip to content
This repository has been archived by the owner on Jul 22, 2024. It is now read-only.

Fix ChoicePrompt button order #1402

Closed
keianhzo opened this issue Jul 16, 2019 · 0 comments · Fixed by #1403
Closed

Fix ChoicePrompt button order #1402

keianhzo opened this issue Jul 16, 2019 · 0 comments · Fixed by #1403
Assignees
@keianhzo
Labels
bug This issue is a software or functional defect Bugzilla Main activity on this bug is in Bugzilla
Milestone
v1.4

Comments

@keianhzo
Copy link
Contributor

keianhzo commented Jul 16, 2019 •
edited
Loading

Hardware

All

Steps to Reproduce

  1. Open https://www.w3schools.com/js/tryit.asp?filename=tryjs_confirm
  2. Open the Js confirm
  3. Click on "ok"

Current Behavior

The log shows

You pressed Cancel!

Expected Behavior

The log should show

You pressed OK!

Possible Solution

At some point there was a GV bug where the choice prompt button order was sent reversed and ok was cancel. That's been fixed and we should update accordingly.
https://bugzilla.mozilla.org/show_bug.cgi?id=1565691

While fixing special attention should be paid to code that is explicitly expecting the wrong button order when using ChoicePromptWidget.

Context

Error Logs and Stack Traces
@keianhzo keianhzo added bug This issue is a software or functional defect Bugzilla Main activity on this bug is in Bugzilla labels Jul 16, 2019
@keianhzo keianhzo self-assigned this Jul 16, 2019
@keianhzo keianhzo mentioned this issue Jul 16, 2019
Merged
@jvonitter jvonitter added this to the v1.4 milestone Jul 16, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@keianhzo keianhzo

Labels
bug This issue is a software or functional defect Bugzilla Main activity on this bug is in Bugzilla
Projects
None yet
Milestone
v1.4
Development

Successfully merging a pull request may close this issue.

Fixed button order in confirm prompt MozillaReality/FirefoxReality
2 participants
@keianhzo @jvonitter