Skip to content
This repository has been archived by the owner on Jul 22, 2024. It is now read-only.

Make sure Glean telemetry is enabled #1420

Closed
grigoryk opened this issue Jul 18, 2019 · 13 comments
Closed

Make sure Glean telemetry is enabled #1420

grigoryk opened this issue Jul 18, 2019 · 13 comments
Assignees
Labels
enhancement This issue is a new feature or request telemetry
Milestone

Comments

@grigoryk
Copy link
Contributor

For feature/fxa. Sync is using glean to send out "sync pings" so that we can track health of this client.

Needs to integrate with telemetry settings.

Follow-up to #1389 and #1417.

@daoshengmu
Copy link
Contributor

@grigoryk it sounds like Mozilla Android Component has already replaced the existing telemetry system to Glean? Is there anything we need to do? Or, we just need to upgrade our version of Android Component?

@philip-lamb philip-lamb added enhancement This issue is a new feature or request P3 Backlog labels Jul 24, 2019
@jvonitter jvonitter added this to the v1.5 milestone Jul 24, 2019
@daoshengmu
Copy link
Contributor

We will consider to replace Telemetry service with Glean in September. There are possible plans:

  1. Using two tables for telemetry service and Glean to confirm the transition will not cause any side effects. Or just use the same table for Glean. We need ask for consultation from Glean team to make decisions.

  2. There is a Glean SDK document [1]. Glean team recommend us before we start, we can consider to provide them our telemetry and the dashboard, they can help us review and give us consultation.

[1] https://mozilla.github.io/glean/book/user/adding-glean-to-your-project.html

@daoshengmu
Copy link
Contributor

@pocmo @Dexterp37
I saw there are some updates about Glean in Android Component.
(https://github.com/mozilla-mobile/android-components/tree/master/components/service/glean)

Does it mean it is available now to replace the existing Service/Telemetry component with Glean via Android Component? Or, you guys still suggest us to choose Glean SDK instead of using Android Component for telemetry?

@daoshengmu daoshengmu self-assigned this Sep 9, 2019
@Dexterp37
Copy link

@daoshengmu , thank you for reaching out. In Android Components, there are currently two libraries for collecting telemetry:

  • service-telemetry, which is deprecated. See its readme.
  • service-glean: this is the Glean SDK. Projects are allowed to use it as they see fit. We are happy to consult with project owners to identify a migration path and help evaluate the efforts to migrate over.

@philip-lamb philip-lamb changed the title Make sure Glean telelemtry is enabled Make sure Glean telemetry is enabled Sep 11, 2019
@jvonitter
Copy link
Contributor

@daoshengmu can you let me know what the timeline is for this?

@jvonitter jvonitter modified the milestones: #5 polish, #6 features Oct 2, 2019
@daoshengmu
Copy link
Contributor

daoshengmu commented Oct 2, 2019

@daoshengmu can you let me know what the timeline is for this?

@jvonitter
There was a blocker by Bug 1582025 and Bug 1582075.

Bug 1582025 has been resolved that means we can have basic pings like OS, Platform, and MAU info for now. But, for other custom metric like UX behavior tracking, we still need to wait for Bug 1582075. I will continue to work on #1854 once these blockers are done.

@Dexterp37
Copy link

Bug 1582025 has been resolved that means we can have basic pings like OS, Platform, and MAU info for now. But, for other custom metric like UX behavior tracking, we still need to wait for Bug 1582075. I will continue to work on #1854 once these blockers are done.

Please note that, as mentioned over Slack, bug 1582075 is not necessarily a blocker for this project, for 2 reasons:

  1. You would really want to add Glean SDK support in a staged fashion (i.e. land the initial support first, then the other metrics).
  2. Most of the metrics support is already available in Java. If that's not the case, please comment on bug 1582075 with the problem you're facing and we'll prioritize accordingly.

Please note that bug 1582075 does not block fxa/sync from sending data, if Glean is enabled.

@daoshengmu
Copy link
Contributor

daoshengmu commented Oct 5, 2019

I would like to separate Glean integration into different stages:

  1. Make sure baseline pings work for us, like user count, os, platform, appName, buildId, etc...That is what FxA needs.
  2. Category.Action of TelemetryEvent, these custom events support in Glean, and confirm data are migrated. like typeUrl, typeQuery, voiceQuery, etc...
  3. Replacing Category.HISTOGRAM of TelemetryEvent with Timespan or other metric types, and confirm data are correct. like loadingTime, immersive, openWindowsTime, etc...

@bluemarvin
Copy link
Contributor

Maybe you should do this in a feature branch.

@pocmo
Copy link
Contributor

pocmo commented Oct 7, 2019

Please also look at issue #1353 (#1300). Glean does use work manager and that may reintroduce the RECEIVE_BOOT_COMPLETED permission.

@daoshengmu
Copy link
Contributor

@Dexterp37 Please help confirm if Glean is using RECEIVE_BOOT_COMPLETED permission? In Oculus app store, we can't use RECEIVE_BOOT_COMPLETED, so we had a workaround fix at #1300.

@Dexterp37
Copy link

@Dexterp37 Please help confirm if Glean is using RECEIVE_BOOT_COMPLETED permission? In Oculus app store, we can't use RECEIVE_BOOT_COMPLETED, so we had a workaround fix at #1300.

Apparently, as @pocmo mentioned, that permission is automatically added when using the WorkManager, see the related google issue. We have bug 1565969 filed for this.

I'd be curious to see if the lack of this permission blocks telemetry completely or makes it flaky. We do not rely on restore after reboot anywhere.

@daoshengmu
Copy link
Contributor

Per #1854, we have enabled Glean and supported its baseline pings.

@philip-lamb philip-lamb removed P3 Backlog labels Oct 30, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement This issue is a new feature or request telemetry
Projects
None yet
Development

No branches or pull requests

7 participants