Enter VR button just going to fullscreen/video, not immersive

[larsbergstrom]

Configuration

Firefox Reality version: 1.4.1
Firefox Reality build ID:

Hardware: HTC Vive Focus Plus

Steps to Reproduce

1. Load a WebVR site (tried on both a Hubs room and the "anime UI" example https://aframe.io/examples/ )
2. Click the button to enter VR

Current Behavior

The experience goes full-screen mode, but stays 2D.

Expected Behavior

Immersive, wrap-around 3D.

Possible Solution

Context

Error Logs and Stack Traces

[bluemarvin]

@larsbergstrom Can get a screen shot of about:support? I was able to reproduce the issue once, but after uninstalling 1.4.1 then running the update from the Vive store, immersive mode works. Also, are you able to see the controllers in FxR?

[bluemarvin]

Actually, never mind. I don't think the Gecko version is the issue.

[bluemarvin]

@larsbergstrom Is this issue 100% reproducible for you? I see very sporadically (twice) but have not found a way to reliably reproduce the issue.

[larsbergstrom]

@bluemarvin I've mainly seen it when the first thing that I load is a very complicated Hubs scene (like the meetups). Otherwise, it's also very intermittent for me. It's gotten into that state for the last 2-3 meetups now, and only when they were in a pretty complicated room.

[bluemarvin]

Okay, based on what I've seen, I think something is preventing FxR from entering immersive mode. Once that happens, immersive mode appears to be broken. Both times I got FxR into this state, after multiple attempts to enter immersive mode, FxR would hang on the immersive spinner and had to be killed and restarted.

[larsbergstrom]

Yes! That sounds right - killing FxR and re-starting does let the "Anime UI" work again.

[philip-lamb]

Appears to be a duplicate of #1777. The Geckoview bug in that issue is now P1.

[bluemarvin]

This is actually a different issue because the VR display exists but fails to go into immersive mode. With #1777 there aren’t any VR displays to even attempt to enter immersive mode and a page reload fixes the issue.

[MortimerGoro]

It seems we are mixing two different issues here:

I posted a GV patch for the fullscreen fallback issue (https://bugzilla.mozilla.org/show_bug.cgi?id=1587366) when a session is restored. In a-frame they fallback to fullscreen when they don't find VRDisplays. This case may be similar to #1777.

If you see the spinner then it's a different issue because the VRDisplay is found

[larsbergstrom]

@MortimerGoro No spinner ever appears in this case.

[bluemarvin]

To be clear, how you can tell the two issues apart, if it is the restore bug, reloading the page will fix it. If it is the immersive mode failure, reloading the page will not fix it. The immersive mode failure is much harder to reproduce.

[MortimerGoro]

I found another race condition which can cause the fullscreen issue. Bugzilla patch here: https://bugzilla.mozilla.org/show_bug.cgi?id=1591949

[bluemarvin]

I believe this was fixed by #2135