Skip to content
This repository has been archived by the owner on Jul 22, 2024. It is now read-only.

Migrate FxA implemetation to WebChannels instead of interceptor #2267

Closed
keianhzo opened this issue Nov 14, 2019 · 4 comments · Fixed by #3498
Closed

Migrate FxA implemetation to WebChannels instead of interceptor #2267

keianhzo opened this issue Nov 14, 2019 · 4 comments · Fixed by #3498
Assignees
Milestone

Comments

@keianhzo
Copy link
Contributor

Is your feature request related to a problem? Please describe.
Since we're using Gecko, we should use WebChannels for communicating with the FxA web content, instead of intercepting URL loads.

Based on this comment: #1973 (comment)

Additional context
Once we integrate the webchannels support, for free we get handling of "Choose what to sync" selection during FxA sign-up, which our current interceptor-based integration doesn't support. Also with a tiny bit of extra work, ability to add "Manage Account" button to your FxA settings page.

This requires WebChannels webext integration.

@jvonitter jvonitter added this to the #8 features milestone Nov 18, 2019
@keianhzo keianhzo removed the blocked label Dec 2, 2019
@jvonitter jvonitter removed their assignment Dec 2, 2019
@keianhzo keianhzo self-assigned this Dec 3, 2019
@keianhzo
Copy link
Contributor Author

@jvonitter We better push this to v9. We have decided to talk to the AC team in the All-Hands and expose them the need of making AC more aware of FxR in general. This is part of that conversation. We should provide time estimation and a proposal to evaluate and maybe contribute.

@jvonitter jvonitter modified the milestones: #8 features, #9 polish Jan 14, 2020
@keianhzo
Copy link
Contributor Author

This is not going to happen for v9. We decided to do a staged migration to better integrate AC-FxR. First stage completed, second should add support for WebChannels in FxR without needing to implement the whole Engine/EngineSession interface.

@bluemarvin bluemarvin modified the milestones: #9 polish, #10 features Feb 25, 2020
@bluemarvin
Copy link
Contributor

This is still blocked on a-c

@keianhzo
Copy link
Contributor Author

@emstanley After the PR lands we are good to start working on Addons support and FxA "Manage Account" settings.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.