Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Token hardening. #906

Open
jschwartzentruber opened this issue Jun 19, 2023 · 2 comments
Open

Token hardening. #906

jschwartzentruber opened this issue Jun 19, 2023 · 2 comments

Comments

@jschwartzentruber
Copy link
Contributor

jschwartzentruber commented Jun 19, 2023

The current API token for crash reporting during fuzzing is an unrestricted token shared by all fuzzing instances and also used for local team members during ad-hoc fuzzing. In the event of a token leak, all crash and signature data on the server can be read.

Some possibilities for improvements:

  1. Add capability for tokens to be write-only for use by fuzzing instances. Done
  2. Implement token expiry to force rotation.
  3. Rate limit tokens to a reasonable maximum to prevent a leaked write-only token from flooding the server.
  4. Segment tokens by tool so tokens can only report crashes for the intended tool.
@jschwartzentruber
Copy link
Contributor Author

  1. IP restrictions for API usage. Automation tokens should be restricted to the datacentres we're using.

@jschwartzentruber
Copy link
Contributor Author

jschwartzentruber commented Jun 26, 2023

2b. django-rest-knox supports token expiry, which could be bumped whenever last-login is updated by UI login. This also solves the problem that SSO account disable does not invalidate tokens.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant