-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Drop dependency on deprecated gulp-util
#54
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, thanks.
@MrBoolean
Could we have this merged and published? Failing CI seems unrelated to this change, could you fix it?
Nope, this is not yet good enough. gulp-run still depends on vinyl 0.4.6, which (from what i gathered) caused the whole ordeal first place. It's also possible that the vinyl test fails for that very reason. I haven't tried yet, but upgrading to vinyl 2.1 might fix the issue. |
I agree with line0. I would suggest the following: we find out if |
The goal of this PR is not to fix issues you previously might have had with your plugin. It simply replaces a deprecated utility package by a functionally equivalent but smaller one. If the tests were failing before, they still will do so now, but the problem is unrelated to the PR or the changes it proposes. I don't know the inner workings or the history of your package, so I'm not sure what the 'whole ordeal' is that you're referring to. So if this is 'not yet good enough', I'm afraid I can't help out any further. But once again, this PR is not trying to fix any and all problems you have with your plugin. |
The "while ordeal" he's referring to is that the outdated |
Here's a reference to why |
Any progress on this? |
Is there any update over two years later? |
Closes #53