Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop dependency on deprecated gulp-util #54

Closed
wants to merge 1 commit into from
Closed

Drop dependency on deprecated gulp-util #54

wants to merge 1 commit into from

Conversation

TheDancingCode
Copy link

Closes #53

Copy link

@demurgos demurgos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks.

@MrBoolean
Could we have this merged and published? Failing CI seems unrelated to this change, could you fix it?

@line0
Copy link

line0 commented Jan 8, 2018

Nope, this is not yet good enough. gulp-run still depends on vinyl 0.4.6, which (from what i gathered) caused the whole ordeal first place. It's also possible that the vinyl test fails for that very reason. I haven't tried yet, but upgrading to vinyl 2.1 might fix the issue.

@m19c
Copy link
Owner

m19c commented Jan 8, 2018

I agree with line0. I would suggest the following: we find out if vinyl is the problem - if so, we should try to update the dependency. If that does not solve the problem, we can consider making a new major release for gulp-run.

@FizzyGalacticus
Copy link

I just tried to look into this, and I found that the current master branch is failing tests as well.

image

@TheDancingCode
Copy link
Author

The goal of this PR is not to fix issues you previously might have had with your plugin. It simply replaces a deprecated utility package by a functionally equivalent but smaller one. If the tests were failing before, they still will do so now, but the problem is unrelated to the PR or the changes it proposes.

I don't know the inner workings or the history of your package, so I'm not sure what the 'whole ordeal' is that you're referring to. So if this is 'not yet good enough', I'm afraid I can't help out any further. But once again, this PR is not trying to fix any and all problems you have with your plugin.

@FizzyGalacticus
Copy link

The "while ordeal" he's referring to is that the outdated vinyl package is the cause of gulp-util breakage.

@FizzyGalacticus
Copy link

Here's a reference to why gulp-util is breaking packages in gulp v4: https://medium.com/gulpjs/gulp-util-ca3b1f9f9ac5

@TheDancingCode
Copy link
Author

Any progress on this?

@2martens
Copy link

2martens commented Jul 9, 2020

Is there any update over two years later?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace deprecated dependency gulp-util
6 participants