Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Adjustable Blur Radius #103

Open
2 tasks done
Soft-Bred opened this issue Nov 30, 2023 · 6 comments
Open
2 tasks done

✨ Adjustable Blur Radius #103

Soft-Bred opened this issue Nov 30, 2023 · 6 comments
Assignees
Labels

Comments

@Soft-Bred
Copy link
Collaborator

Feature Request Description

Wouldn't it be cool if we could also adjust the amount of blur in the footprint preview? It could just be another slider in the preview menu :)

Warp (https://www.warp.dev/) does this, just as an example.

Screenshots

000738@2x
000739@2x
000740@2x

Additional Context

Just for fun ;p

Final Checks

  • My issue title is descriptive
  • This is a single feature request (multiple feature requests should be reported individually)
@MrKai77
Copy link
Owner

MrKai77 commented Nov 30, 2023

Really cool! In addition, I think it'd be cool to be able to add background patterns (ex. a grid) on top of the blur as well!

@MrKai77 MrKai77 self-assigned this Nov 30, 2023
@Soft-Bred
Copy link
Collaborator Author

oooo, even better, never seen that added to any app 👀

Custom hex code tint maybe too 😄

@MrKai77
Copy link
Owner

MrKai77 commented Jan 20, 2024

Alright, so here's a status update on this:

I looked through iTerm2's source code to set the background blur and it looks like it uses a function called CGSSetWindowBackgroundBlurRadiusFunction, and upon further research, I found that it sets the background blur for a window rather than a view itself. For reference, Loop's preview window is actually a window the size of the screen overlayed on top of everything, with a rectangle view that changes its shape of the rectangle based on the selection window action.
Hopefully that makes at least a bit of sense haha

Anyways, I found that this is the function used to make custom blurs of other apps' backgrounds as well, most likely including Warp.
So I guess that the way to go would probably convert the preview view into an actual window so that I can apply custom blur effects on it too :D

@y-u-s-u-f
Copy link

@MrKai77 Any update on this?

@MrKai77
Copy link
Owner

MrKai77 commented Feb 17, 2024

Not yet... but I am planning on doing this soon! For now, I am more focused on fixing bugs :)

@MrKai77
Copy link
Owner

MrKai77 commented Mar 26, 2024

So I guess that the way to go would probably convert the preview view into an actual window so that I can apply custom blur effects on it too :D

Update: With PR #263, I remade the entire preview window to be an actual "window", so that makes implementing this 10x easier!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants