Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add allow_nan_equality option to assert_approx_df_equality #28

Open
mitches-got-glitches opened this issue Apr 22, 2021 · 3 comments · May be fixed by #29
Open

Add allow_nan_equality option to assert_approx_df_equality #28

mitches-got-glitches opened this issue Apr 22, 2021 · 3 comments · May be fixed by #29

Comments

@mitches-got-glitches
Copy link
Contributor

I feel like this would be quite useful. Were there any design choices for why it wasn't included or would this be a useful addition?

chispa/chispa/dataframe_comparer.py

Lines 38 to 40 in 500793e

def assert_approx_df_equality(df1, df2, precision, ignore_nullable=False):
assert_schema_equality(df1.schema, df2.schema, ignore_nullable)
assert_generic_rows_equality(df1, df2, are_rows_approx_equal, [precision])

@MrPowers
Copy link
Owner

@mitches-got-glitches - yea, allow_nan_equality is probably even more important for assert_approx_df_equality. Feel up for sending me a PR?

@mitches-got-glitches
Copy link
Contributor Author

Hi @MrPowers , yes I will have a go this week! Cheers

@MrPowers
Copy link
Owner

Awesome, thanks @mitches-got-glitches!

@mitches-got-glitches mitches-got-glitches linked a pull request Apr 26, 2021 that will close this issue
Draft
6 tasks
@bweisberg bweisberg mentioned this issue Dec 17, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add allow_nan_equality option to assert_approx_df_equality mitches-got-glitches/chispa
2 participants
@MrPowers @mitches-got-glitches