You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Mu2eG4/src/constructTargetPS.cc includes "Offline/GeometryService/inc/ProductionTargetMaker.hh"
While the maker happens to live in GeometryService, and it is OK to depend on the library, this breaks the separation between geometry parsing (the maker classes) and users of the parsed geometry. I think geometry makers are only supposed to be used by GeometryService itself.
There are many other cleanups that would be nice to do in the production target geometry code. Is it time to simplify it by removing the "tier 1" design?
The text was updated successfully, but these errors were encountered:
Mu2eG4/src/constructTargetPS.cc includes "Offline/GeometryService/inc/ProductionTargetMaker.hh"
While the maker happens to live in GeometryService, and it is OK to depend on the library, this breaks the separation between geometry parsing (the maker classes) and users of the parsed geometry. I think geometry makers are only supposed to be used by GeometryService itself.
There are many other cleanups that would be nice to do in the production target geometry code. Is it time to simplify it by removing the "tier 1" design?
The text was updated successfully, but these errors were encountered: