-
Notifications
You must be signed in to change notification settings - Fork 82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fixing bug in assigning uselessTripletSeed #1269
Conversation
Hi @matthewstortini,
which require these tests: build. @Mu2e/fnalbuild-users, @Mu2e/write have access to CI actions on main. ⌛ The following tests have been triggered for ab860ae: build (Build queue is empty) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for getting to this quickly. I have one question inline and one suggestion for a future PR.
☀️ The build tests passed at ab860ae.
N.B. These results were obtained from a build of this Pull Request at ab860ae after being merged into the base branch at 2149850. For more information, please check the job page here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving with the request to follow up in later PRs with the requests made during the review and in issue #1270 .
Please submit the follow up work in self contained, reviewable PRs rather than in fewer PRs each covering many topics.
Just fixing the bug we saw pop up in the nightly validation.
Dave, the other changes are very trivial ones that you asked for in the last PR from Giani that we closed. Hope it's fine I included them.