Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include support for Gradle and Maven #7

Closed
DarkerMinecraft opened this issue Mar 1, 2021 · 9 comments
Closed

Include support for Gradle and Maven #7

DarkerMinecraft opened this issue Mar 1, 2021 · 9 comments
Assignees
Labels
enhancement New feature or request

Comments

@DarkerMinecraft
Copy link

Just a quick suggestion on making it available on Gradle and Maven platforms. You can check at https://jitpack.io but you only need a build file I believe.

@Mudbill
Copy link
Owner

Mudbill commented Mar 2, 2021

I've never actually worked with either. If you think it's worth adding, you can submit a PR.

@nimelord
Copy link

nimelord commented May 4, 2024

I will do if You get me permissions.
Actually I need your lib as a maven artifact.

@Mudbill Mudbill mentioned this issue May 5, 2024
@Mudbill
Copy link
Owner

Mudbill commented May 5, 2024

I will look into publishing it on Maven central.

@Mudbill
Copy link
Owner

Mudbill commented May 7, 2024

Okay, so I think I have set it all up now. Give it a try and let me know if everything works :)

https://central.sonatype.com/artifact/io.github.mudbill/dds-lwjgl

For Maven:

<dependency>
    <groupId>io.github.mudbill</groupId>
    <artifactId>dds-lwjgl</artifactId>
    <version>2.1.1</version>
</dependency>

I might consider moving the package namespace within to match the github namespace I used for the artifact. Although I technically own both, I just found this to be easier.

@Mudbill Mudbill self-assigned this May 7, 2024
@Mudbill Mudbill added the enhancement New feature or request label May 7, 2024
@nimelord
Copy link

Unfortunately I can't use this build.
It downloaded well, but:
[ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.8.1:compile (default-compile) on project zengine: Compilation failure: Compilation failure: [ERROR] /data/projects/zingl/zengine/src/main/java/com/zingl/engine/graph/texture/ImageDecodeUtils.java:[8,31] cannot access net.buttology.lwjgl.dds.DDSFile [ERROR] bad class file: /home/johny/.m2/repository/io/github/mudbill/dds-lwjgl/2.1.1/dds-lwjgl-2.1.1.jar(/net/buttology/lwjgl/dds/DDSFile.class) [ERROR] class file has wrong version 65.0, should be 61.0

That means You use 21 version of jdk to build lib. It is pretty modern and so many platforms still use 17th.)

@Mudbill
Copy link
Owner

Mudbill commented May 13, 2024

Alright, I will look to fix this shortly. Just an oversight on my part – the code should compile fine for JDK 8.
Thanks for letting me know.

@Mudbill
Copy link
Owner

Mudbill commented May 14, 2024

I've published a new version: 3.0.0.
This one should be compatible all the way back to JDK 1.8, so that should fix those issues. Give it a try and let me know 😄

I also optimized some of the dependencies and such. I decided to go with LWJGL version 3.3.0, although it's possible it's supported further back. I'd have to test that.

However I made 1 breaking change (hence the major version): I updated the package to better reflect its component artifact on Central. Instead of importing net.buttology.lwjgl.dds.DDSFile, you must update it to import io.github.mudbill.dds.DDSFile. A simple change, but avoids potential confusion going forward.

@nimelord
Copy link

Now It is working well.
Thank you! :)

@Mudbill
Copy link
Owner

Mudbill commented May 14, 2024

Fantastic, great to know! Closing this one now.

@Mudbill Mudbill closed this as completed May 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants