Missing error message details on non-mandatory-script-verify-flag

[timmclean]

When sendrawtransaction is used with a transaction signature not in canonical form, the following error is returned:

16: ConnectInputs failed: non-mandatory-script-verify-flag (No error)

(No error) should be the actual error message, but it looks like error message is being taken from the wrong CScriptCheck instance:

multichain/src/core/main.cpp

Lines 2147 to 2150 in 4ddb443

	CScriptCheck check(*coins, tx, i,
	flags & ~STANDARD_NOT_MANDATORY_VERIFY_FLAGS, cacheStore);
	if (check())
	return state.Invalid(false, REJECT_NONSTANDARD, strprintf("non-mandatory-script-verify-flag (%s)", ScriptErrorString(check.GetScriptError())));

check is the instance that succeeded, so it is always "No error". The error message from the check that failed should be used instead.

[gidgreen]

Thanks, we'll take a look.