Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scrollTimelinePolyfill is causing errors #594

Closed
Sergiobop opened this issue May 15, 2024 · 1 comment · Fixed by #632
Closed

scrollTimelinePolyfill is causing errors #594

Sergiobop opened this issue May 15, 2024 · 1 comment · Fixed by #632
Labels
polyfill scroll-timeline polyfill

Comments

@Sergiobop
Copy link

Sergiobop commented May 15, 2024

Expected Behavior

No errors

Actual Behavior

I'm using Sentry, and my error log is full of TypeErrors caused by the polyfill. I don't know if we can do something to avoid them.

I will paste some errors:

1 TypeError setNativeCurrentTime(scroll-timeline/src/proxy-animation)

TypeError
Animation.currentTime setter: Value being assigned is not a finite floating-point value.

Sentry points at line 480: setNativeCurrentTime at line 480:42 of https://flackr.github.io/scroll-timeline/src/proxy-animation.js

timeline.currentTime &&
timeline.currentTime.value == (playbackRate < 0 ? 0 : 100);
const delta = atScrollTimelineBoundary ? (playbackRate < 0 ? 0.001 : -0.001) : 0;
details.animation.currentTime = time + delta; // This one

2 TypeError The provided value is non-finite (same line, details.animation.currentTime = time + delta;)

The provided value is non-finite

Environment

  • Angular: 17
  • ngx-scrollbar: 14.1

Looks like other people have the problem too:
flackr/scroll-timeline#254 (comment)

@MurhafSousli
Copy link
Owner

MurhafSousli commented May 30, 2024

I am not familiar with Sentry, but I guess I get the idea, you need to find an option in Sentry to ignore this file. the polyfill is pure JS, and has no types and these kind of systems will always complain about typo stuff. The other option is to try to convince polyfill dev team, it is outside our control.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
polyfill scroll-timeline polyfill
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants