Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Firefox flickers on loading scrollbar/polyfill #631

Closed
daniel-sc opened this issue Jul 19, 2024 · 7 comments · Fixed by #632
Closed

Firefox flickers on loading scrollbar/polyfill #631

daniel-sc opened this issue Jul 19, 2024 · 7 comments · Fixed by #632
Labels
need: feedback polyfill scroll-timeline polyfill

Comments

@daniel-sc
Copy link

Reproduction

@MurhafSousli it seems there is still (probably related to #615) some issue with that polyfill - I am using v15.1.0 and (still) get a short flicker when the scrollbar/polyfill is loaded, where all styles quickly get reset, see attached video/gif (in reality it is shorter, I artificially slowed down the relevant 2 frames..):

firefox-flicker

Expected Behavior

All existing styles already loaded should not (visibly) changed/updated.

Actual Behavior

For a short period some(?) styles get reset.

Environment

  • Angular: 18.1
  • ngx-scrollbar: 15.1.0
  • Browser(s): Firefox 128.0 (64-Bit)
  • Operating System (e.g. Windows, macOS, Ubuntu): Win10
@MurhafSousli MurhafSousli added the polyfill scroll-timeline polyfill label Jul 20, 2024
@MurhafSousli
Copy link
Owner

MurhafSousli commented Jul 20, 2024

Could you try this polyfill URL and tell if it fixes the issue https://cdn.statically.io/gist/MurhafSousli/c852b6a672069396953f06ddd4b64620/raw/0b2553be83108b96b442c7004b08ef57c9282bfe/scroll-timeline-lite.js

import { provideScrollbarPolyfill } from 'ngx-scrollbar';

export const appConfig: ApplicationConfig = {
  providers: [
    provideScrollbarPolyfill(polyfillURL)
  ]
};

@daniel-sc
Copy link
Author

@MurhafSousli yes, this seems to fix the issue!

@daniel-sc
Copy link
Author

daniel-sc commented Jul 22, 2024

note: using the new polyfill (scoll-timeline-lite.js) I observed the following error in FF

image

I can reproduce this on a specific route change / navigation..

@MurhafSousli
Copy link
Owner

@daniel-sc how to reproduce it?

@daniel-sc
Copy link
Author

@MurhafSousli I uploaded a small reproduction: https://github.com/daniel-sc/ngx-scrollbar-reproduce-polyfill-error
You can run it locally with ng serve and observe the issue in FF on clicking "toggle".

@bruno-lopes
Copy link

#624 (comment) Seems to fixes this issue.

@MurhafSousli MurhafSousli linked a pull request Jul 25, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
need: feedback polyfill scroll-timeline polyfill
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants