-
Notifications
You must be signed in to change notification settings - Fork 127
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Share-button doesn't work for Angular 9 SSR part. #453
Comments
It seems that the errors thrown is caused by FontAwesome package, did you install the package? |
Yes. I already installed them. |
I haven't tested the beta release yet in SSR. Can you upload the project and give me the link |
angular9-starter.zip
|
You didn't mention that the app is working properly, the icons is shown without errors in the browser, the errors show only in the express console. The code in ngx-sharebuttons source code looks fine, I have reported this to Angular FontAwesome repo, let's see what they say! |
So, Is it related to the Angular FontAwesome Repository? |
and what is this |
See ShareIconModule in If you like you can remove this module, and include the icons manually in your app, but you will still get the same errors in the console. the error is in |
@Ambitiont109 I've published a new release |
Then Do we also have to raise the issue in fa-icon packages? |
OKay. I see. Let me try right now. |
Hello! I have tried again. And got the below issue. |
Hello |
@Ambitiont109 I have tried it and it worked on my end, can you please try with this repo, I've added Universal to the demo. After cloning the repo, try the following:
Please ignore any warnings for now! let's make sure the errors are disappeared |
Hello I checked your repository. And It doesn't get any error. |
Hello. |
I fixed it now, will release v8.0.0 |
Okay. I see. |
Hello |
I am submitting a
What is the expected behavior?
No Errors
What is the current behavior?
ERROR Error: Property
icon
is required forfa-icon
/fa-duotone-icon
components.at faWarnIfIconSpecMissing (C:\Users\Ambition\Downloads\angular9-starter\dist\angular9-starter\server\main.js:107755:11)
at FaIconComponent.ngOnChanges (C:\Users\Ambition\Downloads\angular9-starter\dist\angular9-starter\server\main.js:107838:20)
at FaIconComponent.wrapOnChangesHook_inPreviousChangesStorage (C:\Users\Ambition\Downloads\angular9-starter\dist\angular9-starter\server\main.js:73774:18)
at callHook (C:\Users\Ambition\Downloads\angular9-starter\dist\angular9-starter\server\main.js:52968:14)
at callHooks (C:\Users\Ambition\Downloads\angular9-starter\dist\angular9-starter\server\main.js:52928:17)
at executeInitAndCheckHooks (C:\Users\Ambition\Downloads\angular9-starter\dist\angular9-starter\server\main.js:52868:9)
at refreshView (C:\Users\Ambition\Downloads\angular9-starter\dist\angular9-starter\server\main.js:59357:21)
at refreshEmbeddedViews (C:\Users\Ambition\Downloads\angular9-starter\dist\angular9-starter\server\main.js:60735:17)
at refreshView (C:\Users\Ambition\Downloads\angular9-starter\dist\angular9-starter\server\main.js:59366:9)
at refreshComponent (C:\Users\Ambition\Downloads\angular9-starter\dist\angular9-starter\server\main.js:60789:13)
ERROR Error: Property
icon
is required forfa-icon
/fa-duotone-icon
components.at faWarnIfIconSpecMissing (C:\Users\Ambition\Downloads\angular9-starter\dist\angular9-starter\server\main.js:107755:11)
at FaIconComponent.ngOnChanges (C:\Users\Ambition\Downloads\angular9-starter\dist\angular9-starter\server\main.js:107838:20)
at FaIconComponent.wrapOnChangesHook_inPreviousChangesStorage (C:\Users\Ambition\Downloads\angular9-starter\dist\angular9-starter\server\main.js:73774:18)
at callHook (C:\Users\Ambition\Downloads\angular9-starter\dist\angular9-starter\server\main.js:52968:14)
at callHooks (C:\Users\Ambition\Downloads\angular9-starter\dist\angular9-starter\server\main.js:52928:17)
at executeInitAndCheckHooks (C:\Users\Ambition\Downloads\angular9-starter\dist\angular9-starter\server\main.js:52868:9)
at refreshView (C:\Users\Ambition\Downloads\angular9-starter\dist\angular9-starter\server\main.js:59357:21)
at refreshEmbeddedViews (C:\Users\Ambition\Downloads\angular9-starter\dist\angular9-starter\server\main.js:60735:17)
at refreshView (C:\Users\Ambition\Downloads\angular9-starter\dist\angular9-starter\server\main.js:59366:9)
at refreshComponent (C:\Users\Ambition\Downloads\angular9-starter\dist\angular9-starter\server\main.js:60789:13)
What are the steps to reproduce?
What is the use-case or motivation for changing an existing behavior?
Which versions are you using for the following packages?
Angular CLI: 9.1.7
Node: 12.13.0
OS: win32 x64
Angular: 9.1.9
... animations, common, compiler, compiler-cli, core, forms
... language-service, platform-browser, platform-browser-dynamic
... platform-server, router
Ivy Workspace: Yes
Package Version
@angular-devkit/architect 0.901.7
@angular-devkit/build-angular 0.901.7
@angular-devkit/build-optimizer 0.901.7
@angular-devkit/build-webpack 0.901.7
@angular-devkit/core 9.1.7
@angular-devkit/schematics 9.1.7
@angular/cdk 9.2.4
@angular/cli 9.1.7
@ngtools/webpack 9.1.7
@nguniversal/builders 9.1.1
@nguniversal/common 9.1.1
@nguniversal/express-engine 9.1.1
@schematics/angular 9.1.7
@schematics/update 0.901.7
rxjs 6.5.5
typescript 3.8.3
webpack 4.42.0
Is there anything else we should know?
I just created the new blank angular 9 projects and added the
ShareButtonsModule.withConfig({debug:true}),
ShareIconsModule
on app.module.ts.
And Used share-button simply on app.compoent.html.
Here is the raw data of app.compoent.html
The text was updated successfully, but these errors were encountered: