Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue with ngx- popup #516

Closed
1 task done
Alsmith141510 opened this issue Dec 13, 2020 · 1 comment
Closed
1 task done

Issue with ngx- popup #516

Alsmith141510 opened this issue Dec 13, 2020 · 1 comment

Comments

@Alsmith141510
Copy link

I am submitting a

  • Bug Report

What is the expected behavior?

I am facing two issues

  1. When using the popup button.
    IT errors out stating that it could not find share image. I believe the share icon is not part of your package.
  2. When using the include option. the component is putting in the URL: over the share. There is no way to remove it. In my development environment even though I give the URL for my prod site it displays localhost.

What is the current behavior?

  1. doesn't work.
  2. I am trying to use the popup button. I can bring up the modal window. but on the top as indicated in the picture along with the word 'Share'. has the 'localhost. '. I have tried everything to suppress it but have been unsuccessful.

What are the steps to reproduce?

sharebutton_err
setup Ngx-sharebutton with popup.

<button shareButtonsPopup [theme]="'circles-dark'" [include]="['facebook','twitter','linkedin','pinterest','reddit','tumblr','mix','viber','telegram','messenger','whatsapp','xing','line','sms']"
[class]="'sb-icon'"
[exclude]="['reddit','tumblr','mix','vk','telegram','print','copy']"
[title]="''"
[description]="''"
[tags]="'teach, learn'"
[autoSetMeta]="false">share-alt

What is the use-case or motivation for changing an existing behavior?

I have gotten around first issue with using
<button shareButtonsPopup class="share-icon" [theme]="'circles-dark'"
[include]="['facebook','twitter','linkedin','pinterest','reddit','tumblr','mix','viber','telegram','messenger','whatsapp','xing','line','sms']"
[title]="'Education platform for the masses - Teachanytime changing the education paradigm'"
[description]="'Take Classes or teach them anytime, anywhere. Reach a Global audience or a local one, teachnaytime make it easy for the both for teachers or Students of any level.'"
[tags]="'teach, learn'"
[autoSetMeta]="false">share-alt

  1. On the second issue I have taken out the complete [exclude] option so I am good now but it is prickly. took a while to figure out.

Which versions are you using for the following packages?

Angular: 10.0.5
Angular CDK: 10.1.0
Angular CLI: 10.0.4
Angular-fontawesome: "@fortawesome/angular-fontawesome": "0.8.0",
"@fortawesome/fontawesome-svg-core": "1.2.32",
"@fortawesome/free-brands-svg-icons": "5.15.1",
"@fortawesome/free-solid-svg-icons": "5.15.1"
ngx-sharebuttons: 8.0.4

Is there anything else we should know?

I have gotten around first issue with using
<button shareButtonsPopup class="share-icon" [theme]="'circles-dark'"
[include]="['facebook','twitter','linkedin','pinterest','reddit','tumblr','mix','viber','telegram','messenger','whatsapp','xing','line','sms']"
[title]="'Education platform for the masses - Teachanytime changing the education paradigm'"
[description]="'Take Classes or teach them anytime, anywhere. Reach a Global audience or a local one, teachnaytime make it easy for the both for teachers or Students of any level.'"
[tags]="'teach, learn'"
[autoSetMeta]="false">share-alt

  1. On the second issue I have taken out the complete [exclude] option so I am good now but it is prickly. took a while to figure out.
@MurhafSousli
Copy link
Owner

MurhafSousli commented Dec 17, 2020

The pop up component is still not completed, I haven't got the time to finalize it, so you may want to adjust the css manually if you are using the circle buttons

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants