Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build fail release 1.3.0 #626

Closed
Pro-pra opened this issue Aug 27, 2023 · 5 comments
Closed

Build fail release 1.3.0 #626

Pro-pra opened this issue Aug 27, 2023 · 5 comments

Comments

@Pro-pra
Copy link

Pro-pra commented Aug 27, 2023

Hi all, google not help me there GIT_BUF_INIT_CONST provided :(

/src/git/Branch.cpp:86:17: error: 'GIT_BUF_INIT_CONST' was not declared in this scope; did you mean 'GIT_BUF_INIT'?
   86 |   git_buf buf = GIT_BUF_INIT_CONST(nullptr, 0);
      |                 ^~~~~~~~~~~~~~~~~~
      |                 GIT_BUF_INIT
@Murmele
Copy link
Owner

Murmele commented Aug 29, 2023

Hi,
which version of libgit2 are you using?
Did you execute git submodule update --init --recursive?

@Pro-pra
Copy link
Author

Pro-pra commented Aug 30, 2023

yes, i launch git submodule update --init --recursive

I use system libgit2-1.7.1 and bundled libgit2 with option USE_SYSTEM_LIBGIT2=OFF

this option now deprecated in libgit2 and found in deprecated.h
https://github.com/libgit2/libgit2/blob/da265cdf2ed7f7338178b9ed5768af211656e50b/include/git2/deprecated.h#L197

@Murmele
Copy link
Owner

Murmele commented Aug 30, 2023

USE_SYSTEM_LIBGIT2=OFF sounds good, because we are using a patched version of libgit2. Be sure that the bundled libgit version is used.

@Pro-pra
Copy link
Author

Pro-pra commented Aug 30, 2023

USE_SYSTEM_LIBGIT2=OFF is help me, thank you!

@Pro-pra Pro-pra closed this as completed Aug 30, 2023
@Murmele
Copy link
Owner

Murmele commented Aug 30, 2023

Ah ok you had USE_SYSTEM_LIBGIT2=ON previously.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants