Build fails on Mint 21.3

[readmodifywrite]

Build is failing on Linux Mint 21.3:

Lots of errors like this:

FAILED: src/ui/CMakeFiles/ui.dir/CommitList.cpp.o 
/usr/bin/c++ -DQT_CONCURRENT_LIB -DQT_CORE_LIB -DQT_GUI_LIB -DQT_NETWORK_LIB -DQT_NO_DEBUG -DQT_WIDGETS_LIB -DSCINTILLA_QT -DSCI_LEXER -DSCI_NAMESPACE -I/home/jeremy/JEREMY/Gittyup/build/release/src/ui/ui_autogen/include -I/home/jeremy/JEREMY/Gittyup/src -I/home/jeremy/JEREMY/Gittyup/build/release/src/ui -I/home/jeremy/JEREMY/Gittyup/dep/lua/lua-5.3.4/src -I/home/jeremy/JEREMY/Gittyup/dep/libgit2/libgit2/include -I/home/jeremy/JEREMY/Gittyup/dep/lpeg/lpeg-1.0.1 -I/home/jeremy/JEREMY/Gittyup/dep/scintilla/scintilla-3.6.0/include -I/home/jeremy/JEREMY/Gittyup/dep/scintilla/scintilla-3.6.0/lexlib -I/home/jeremy/JEREMY/Gittyup/dep/scintilla/scintilla-3.6.0/src -I/home/jeremy/JEREMY/Gittyup/dep/cmark/cmark/src -I/home/jeremy/JEREMY/Gittyup/build/release/dep/cmark/cmark/src -isystem /usr/include/x86_64-linux-gnu/qt5 -isystem /usr/include/x86_64-linux-gnu/qt5/QtCore -isystem /usr/lib/x86_64-linux-gnu/qt5/mkspecs/linux-g++ -isystem /usr/include/x86_64-linux-gnu/qt5/QtGui -isystem /usr/include/x86_64-linux-gnu/qt5/QtNetwork -isystem /usr/include/x86_64-linux-gnu/qt5/QtConcurrent -isystem /usr/include/x86_64-linux-gnu/qt5/QtWidgets -fno-exceptions -fno-rtti -O3 -DNDEBUG -fPIC -std=gnu++11 -MD -MT src/ui/CMakeFiles/ui.dir/CommitList.cpp.o -MF src/ui/CMakeFiles/ui.dir/CommitList.cpp.o.d -o src/ui/CMakeFiles/ui.dir/CommitList.cpp.o -c /home/jeremy/JEREMY/Gittyup/src/ui/CommitList.cpp
In file included from /home/jeremy/JEREMY/Gittyup/src/ui/CommitList.cpp:13:
/home/jeremy/JEREMY/Gittyup/src/ui/MainWindow.h:32:29: warning: ‘constexpr QFlags<T>::QFlags(QFlags<T>::Zero) [with Enum = Qt::WindowType; QFlags<T>::Zero = int QFlags<Qt::WindowType>::Private::*]’ is deprecated: Use default constructor instead [-Wdeprecated-declarations]
   32 |     Qt::WindowFlags flags = 0);
      |                             ^
In file included from /usr/include/x86_64-linux-gnu/qt5/QtCore/qglobal.h:1299,
                 from /usr/include/x86_64-linux-gnu/qt5/QtCore/qsharedpointer.h:43,
                 from /usr/include/x86_64-linux-gnu/qt5/QtCore/QSharedPointer:1,
                 from /home/jeremy/JEREMY/Gittyup/src/git/AnnotatedCommit.h:13,
                 from /home/jeremy/JEREMY/Gittyup/src/git/Repository.h:13,
                 from /home/jeremy/JEREMY/Gittyup/src/git/Reference.h:13,
                 from /home/jeremy/JEREMY/Gittyup/src/ui/CommitList.h:13,
                 from /home/jeremy/JEREMY/Gittyup/src/ui/CommitList.cpp:10:
/usr/include/x86_64-linux-gnu/qt5/QtCore/qflags.h:123:80: note: declared here
  123 |     QT_DEPRECATED_X("Use default constructor instead") Q_DECL_CONSTEXPR inline QFlags(Zero) noexcept : i(0) {}
      |                                                                                ^~~~~~
/home/jeremy/JEREMY/Gittyup/src/ui/CommitList.cpp: In member function ‘virtual void {anonymous}::CommitDelegate::paint(QPainter*, const QStyleOptionViewItem&, const QModelIndex&) const’:
/home/jeremy/JEREMY/Gittyup/src/ui/CommitList.cpp:767:26: error: aggregate ‘QPainterPath path’ has incomplete type and cannot be defined
  767 |             QPainterPath path;
      |                          ^~~~
/home/jeremy/JEREMY/Gittyup/src/ui/CommitList.cpp:775:26: error: aggregate ‘QPainterPath path’ has incomplete type and cannot be defined
  775 |             QPainterPath path;
      |                          ^~~~
/home/jeremy/JEREMY/Gittyup/src/ui/CommitList.cpp:783:26: error: aggregate ‘QPainterPath path’ has incomplete type and cannot be defined
  783 |             QPainterPath path;
      |                          ^~~~
/home/jeremy/JEREMY/Gittyup/src/ui/CommitList.cpp:791:26: error: aggregate ‘QPainterPath path’ has incomplete type and cannot be defined
  791 |             QPainterPath path;
      |                          ^~~~
/home/jeremy/JEREMY/Gittyup/src/ui/CommitList.cpp:833:34: warning: ‘int QFontMetrics::width(const QString&, int) const’ is deprecated: Use QFontMetrics::horizontalAdvance [-Wdeprecated-declarations]
  833 |       if (rect.width() > fm.width(name) + fm.width(timestamp) + 8) {
      |                          ~~~~~~~~^~~~~~
In file included from /usr/include/x86_64-linux-gnu/qt5/QtWidgets/qwidget.h:50,
                 from /usr/include/x86_64-linux-gnu/qt5/QtWidgets/qframe.h:44,
                 from /usr/include/x86_64-linux-gnu/qt5/QtWidgets/qabstractscrollarea.h:44,
                 from /usr/include/x86_64-linux-gnu/qt5/QtWidgets/qabstractitemview.h:44,
                 from /usr/include/x86_64-linux-gnu/qt5/QtWidgets/qlistview.h:44,
                 from /usr/include/x86_64-linux-gnu/qt5/QtWidgets/QListView:1,
                 from /home/jeremy/JEREMY/Gittyup/src/ui/CommitList.h:14,
                 from /home/jeremy/JEREMY/Gittyup/src/ui/CommitList.cpp:10:
/usr/include/x86_64-linux-gnu/qt5/QtGui/qfontmetrics.h:106:9: note: declared here
  106 |     int width(const QString &, int len = -1) const;
      |         ^~~~~
/home/jeremy/JEREMY/Gittyup/src/ui/CommitList.cpp:833:51: warning: ‘int QFontMetrics::width(const QString&, int) const’ is deprecated: Use QFontMetrics::horizontalAdvance [-Wdeprecated-declarations]
  833 |       if (rect.width() > fm.width(name) + fm.width(timestamp) + 8) {
      |                                           ~~~~~~~~^~~~~~~~~~~
In file included from /usr/include/x86_64-linux-gnu/qt5/QtWidgets/qwidget.h:50,
                 from /usr/include/x86_64-linux-gnu/qt5/QtWidgets/qframe.h:44,
                 from /usr/include/x86_64-linux-gnu/qt5/QtWidgets/qabstractscrollarea.h:44,
                 from /usr/include/x86_64-linux-gnu/qt5/QtWidgets/qabstractitemview.h:44,
                 from /usr/include/x86_64-linux-gnu/qt5/QtWidgets/qlistview.h:44,
                 from /usr/include/x86_64-linux-gnu/qt5/QtWidgets/QListView:1,
                 from /home/jeremy/JEREMY/Gittyup/src/ui/CommitList.h:14,
                 from /home/jeremy/JEREMY/Gittyup/src/ui/CommitList.cpp:10:
/usr/include/x86_64-linux-gnu/qt5/QtGui/qfontmetrics.h:106:9: note: declared here
  106 |     int width(const QString &, int len = -1) const;
      |         ^~~~~
ninja: build stopped: subcommand failed.

Note that the flatpak also does not work on 21.3. Some KDE dep failure or somesuch (I thought flatpak was supposed to fix dep hell?).

[Murmele]

Hi, can you append the complete log?

How did you try to compile the flatpak version? The CI is creating also nightlies: https://github.com/Murmele/Gittyup/releases

[readmodifywrite]

So, I did a rebuild to try and get you a log, and miraculously, now the build is working.

I reinstalled the deps from the buildUbuntu.sh script. Maybe QT5 needed to be updated? I had already installed it fresh from before, so I'm not really sure what was going on.