Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make diff view include all files by default #702

Closed
jensenr30 opened this issue Feb 26, 2024 · 1 comment
Closed

Make diff view include all files by default #702

jensenr30 opened this issue Feb 26, 2024 · 1 comment

Comments

@jensenr30
Copy link
Contributor

When I click on a commit in the CommitList, "Committed Files" will only ever have one item selected by default. In this example, it happens to be the src directory:

image

Wouldn't it be nice if all files were selected by default? That way, the user would see all changes in the diff view without doing any extra work:

image

However, having all files selected adds visual clutter. And it's possible to select no files. And if no files are selected, wouldn't it make sense to treat that the same as having all files selected?

image

Therefore, my proposal is to make the following behavior default:

  • when the user selects a commit in the CommitList, Committed Files will update to have no files selected.
  • when no files are selected in Committed Files, that is treated the same as having all files selected.

Thoughts?

If this sounds good, feel free to assign to me.

@jensenr30
Copy link
Contributor Author

duplicate of #7

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant