Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding additional mod support #15

Open
ironchefpython opened this issue Nov 12, 2017 · 1 comment
Open

Adding additional mod support #15

ironchefpython opened this issue Nov 12, 2017 · 1 comment

Comments

@ironchefpython
Copy link

I looked through the project, and I didn't see a list of mods that get published to https://factorio.rotol.me/

I would love to be able to submit a pull request that adds an entry to a list of mods to display on the website, and if accepted would rebuild the web page to add those mod(s)

@Murnto
Copy link
Owner

Murnto commented Nov 13, 2017

The current process is:

This isn't an ideal process, there would be a number of things to consider for an automated system:

  • Proper sandboxing/isolation of Lua within Factorio-PackGen
  • Factorio-PackGen is liable to break due to quirks in certain mods (these are generally trivial to fix by hand, but automatically handling it likely won't be)

More minor:

  • Obtaining the mod files
  • Handling changed mod dependencies from version to version

You're more than welcome to submit a PR :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants