Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add function to resync hermes dms #1171

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

benthecarman
Copy link
Collaborator

Closes #1163

@benthecarman benthecarman requested a review from TonyGiorgio May 8, 2024 16:52
@TonyGiorgio
Copy link
Contributor

Should we just have this in the sync chain part? or another button in the admin page?

I would also like to know why it's happening in the first place, this is a bandaid fix.

@benthecarman
Copy link
Collaborator Author

Should we just have this in the sync chain part? or another button in the admin page?

i think its better as a separate function here, for the front end we can do whatever

I would also like to know why it's happening in the first place, this is a bandaid fix.

I am not 100% sure, my guess is that relays are giving us events ordered latest first, so if the app is closed before they are all done, we may miss some events. Not really sure how to best fix this however, there isn't a way to specificy a sort order in a nostr filter, only real fix would be to ask the hermes server

@TonyGiorgio
Copy link
Contributor

The "don't parse DMs before this date" logic is the problem here. We need to remove it.

@benthecarman
Copy link
Collaborator Author

The "don't parse DMs before this date" logic is the problem here. We need to remove it.

We need something, otherwise we have to do a full rescan everytime which slows down the wallet to a crawl.

Maybe saving the timestamp of when we last finished processing all events instead of individual events

@TonyGiorgio
Copy link
Contributor

Maybe saving the timestamp of when we last finished processing all events instead of individual events

Sure, and then back date it 30 days so we know we aren't missing money

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Lightning address payments not being received after a restart
2 participants