[CLEANUP] Avoid Hungarian notation in OutputFormat (part 8) (#1125)

Also rename the getters to match the new property names.

Part of #756

Author: oliverklee

src/OutputFormat.php

@@ -149,14 +149,14 @@ class OutputFormat
      *
      * @var string
      */
-    private $sIndentation = "\t";
+    private $indentation = "\t";
 
     /**
      * Output exceptions.
      *
      * @var bool
      */
-    private $bIgnoreExceptions = false;
+    private $shouldIgnoreExceptions = false;
 
     /**
      * Render comments for lists and RuleSets
@@ -609,33 +609,33 @@ public function setAfterDeclarationBlock(string $content): self
      */
     public function getIndentation(): string
     {
-        return $this->sIndentation;
+        return $this->indentation;
     }
 
     /**
      * @return $this fluent interface
      */
     public function setIndentation(string $indentation): self
     {
-        $this->sIndentation = $indentation;
+        $this->indentation = $indentation;
 
         return $this;
     }
 
     /**
      * @internal
      */
-    public function getIgnoreExceptions(): bool
+    public function shouldIgnoreExceptions(): bool
     {
-        return $this->bIgnoreExceptions;
+        return $this->shouldIgnoreExceptions;
     }
 
     /**
      * @return $this fluent interface
      */
     public function setIgnoreExceptions(bool $ignoreExceptions): self
     {
-        $this->bIgnoreExceptions = $ignoreExceptions;
+        $this->shouldIgnoreExceptions = $ignoreExceptions;
 
         return $this;
     }
@@ -697,7 +697,7 @@ public function nextLevel(): self
 
     public function beLenient(): void
     {
-        $this->bIgnoreExceptions = true;
+        $this->shouldIgnoreExceptions = true;
     }
 
     /**

src/OutputFormatter.php

@@ -148,7 +148,7 @@ public function spaceBeforeOpeningBrace(): string
      */
     public function safely(callable $callable): ?string
     {
-        if ($this->outputFormat->getIgnoreExceptions()) {
+        if ($this->outputFormat->shouldIgnoreExceptions()) {
             // If output exceptions are ignored, run the code with exception guards
             try {
                 return $callable();

tests/Unit/OutputFormatTest.php

@@ -660,9 +660,9 @@ public function setIndentationProvidesFluentInterface(): void
     /**
      * @test
      */
-    public function getIgnoreExceptionsInitiallyReturnsFalse(): void
+    public function shouldIgnoreExceptionsInitiallyReturnsFalse(): void
     {
-        self::assertFalse($this->subject->getIgnoreExceptions());
+        self::assertFalse($this->subject->shouldIgnoreExceptions());
     }
 
     /**
@@ -674,7 +674,7 @@ public function setIgnoreExceptionsSetsIgnoreExceptions(bool $value): void
     {
         $this->subject->setIgnoreExceptions($value);
 
-        self::assertSame($value, $this->subject->getIgnoreExceptions());
+        self::assertSame($value, $this->subject->shouldIgnoreExceptions());
     }
 
     /**
@@ -866,7 +866,7 @@ public function beLenientSetsIgnoreExceptionsToTrue(): void
 
         $this->subject->beLenient();
 
-        self::assertTrue($this->subject->getIgnoreExceptions());
+        self::assertTrue($this->subject->shouldIgnoreExceptions());
     }
 
     /**