-
Notifications
You must be signed in to change notification settings - Fork 148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Run the parser tests with both strict and lenient parsing #455
Comments
Some tests do fail with strict parsing, because they have deliberately invalid constructs. So this is not as easy to achieve as it might sound. However, there is already a file naming convention in the fixtures (used for tests that should pass, and those that should fail) that could be extended... |
For now, I'm adding the naming convention of a filename starting with |
Actually, I'd like to get rid of the switch for strict/lenient parsing (because it add so much complexity both to the code and our testing efforts) and use a default mode instead that mimics what browsers do. I added this to my "road to version 9.0.0" discussion: #454 |
#352 only occurred with strict parsing, so was not picked up by the tests.
IIRC, there are some contructs in PHPUnit to run a whole TestCase more than once with differing 'global' parameters. I remember looking into it, but don't recall the details, and never used it.
The text was updated successfully, but these errors were encountered: