bug with parsing multiple comments #173
Comments
snake
added a commit
to snake/PHP-CSS-Parser
that referenced
this issue
Nov 4, 2019
This fixes MyIntervals#173. Because of an eager consumption of whitespace, the rule and csslist parsing would swallow a trailing comment, meaning the comment for the next rule/list would be affected. This patch addresses this by not consuming whitespace after a rule/list.
ziegenberg
added a commit
to ziegenberg/PHP-CSS-Parser
that referenced
this issue
Aug 24, 2024
Because of an eager consumption of whitespace, the rule parsing would swallow a trailing comment, meaning the comment for the next rule would be affected. This patch addresses this by only consuming real whitespace without comments after a rule. Fixes MyIntervals#173 Signed-off-by: Daniel Ziegenberg <daniel@ziegenberg.at>
ziegenberg
added a commit
to ziegenberg/PHP-CSS-Parser
that referenced
this issue
Aug 24, 2024
Because of an eager consumption of whitespace, the rule parsing would swallow a trailing comment, meaning the comment for the next rule would be affected. This patch addresses this by only consuming real whitespace without comments after a rule. Fixes MyIntervals#173 Signed-off-by: Daniel Ziegenberg <daniel@ziegenberg.at>
ziegenberg
added a commit
to ziegenberg/PHP-CSS-Parser
that referenced
this issue
Aug 24, 2024
Because of an eager consumption of whitespace, the rule parsing would swallow a trailing comment, meaning the comment for the next rule would be affected. This patch addresses this by only consuming real whitespace without comments after a rule. Fixes MyIntervals#173 Signed-off-by: Daniel Ziegenberg <daniel@ziegenberg.at>
ziegenberg
added a commit
to ziegenberg/PHP-CSS-Parser
that referenced
this issue
Aug 25, 2024
Because of an eager consumption of whitespace, the rule parsing would swallow a trailing comment, meaning the comment for the next rule would be affected. This patch addresses this by only consuming real whitespace without comments after a rule. Fixes MyIntervals#173 Signed-off-by: Daniel Ziegenberg <daniel@ziegenberg.at>
ziegenberg
added a commit
to ziegenberg/PHP-CSS-Parser
that referenced
this issue
Aug 25, 2024
Because of an eager consumption of whitespace, the rule parsing would swallow a trailing comment, meaning the comment for the next rule would be affected. This patch addresses this by only consuming real whitespace without comments after a rule. Fixes MyIntervals#173 Signed-off-by: Daniel Ziegenberg <daniel@ziegenberg.at>
ziegenberg
added a commit
to ziegenberg/PHP-CSS-Parser
that referenced
this issue
Aug 25, 2024
…s#671) Because of an eager consumption of whitespace, the rule parsing would swallow a trailing comment, meaning the comment for the next rule would be affected. This patch addresses this by only consuming real whitespace without comments after a rule. Fixes MyIntervals#173 Signed-off-by: Daniel Ziegenberg <daniel@ziegenberg.at>
oliverklee
pushed a commit
that referenced
this issue
Aug 25, 2024
Because of an eager consumption of whitespace, the rule parsing would swallow a trailing comment, meaning the comment for the next rule would be affected. This patch addresses this by only consuming real whitespace without comments after a rule. Fixes #173 Signed-off-by: Daniel Ziegenberg <daniel@ziegenberg.at>
oliverklee
pushed a commit
that referenced
this issue
Aug 25, 2024
Because of an eager consumption of whitespace, the rule parsing would swallow a trailing comment, meaning the comment for the next rule would be affected. This patch addresses this by only consuming real whitespace without comments after a rule. Fixes #173 Signed-off-by: Daniel Ziegenberg <daniel@ziegenberg.at>
oliverklee
added a commit
that referenced
this issue
Aug 25, 2024
Because of an eager consumption of whitespace, the rule parsing would swallow a trailing comment, meaning the comment for the next rule would be affected. This patch addresses this by only consuming real whitespace without comments after a rule. Fixes #173 Signed-off-by: Daniel Ziegenberg <daniel@ziegenberg.at> Co-authored-by: Daniel Ziegenberg <daniel@ziegenberg.at>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
When parsing a rule or csslist, trailing comments (those comments after the rule/list) are consumed as part of a final consumeWhitespace call, meaning we don't see these reported for the next rule in the set (or the next set).
Consider the following cases:
div {/*Find Me!*/left:10px; /*Find Me Too!*/text-align:left;}Both of these comments should be returned (one for each rule), but the latter is not.
/*Find Me!*/div {left:10px; text-align:left;} /*Find Me Too!*/a {left:10px;}Both of these comments should be returned (one for each csslist), but the latter is not.
I'd like this fixed so I can use this to parse RTL directives for css rules/lists reliably again. Moodle recently upgraded to 8.3.0 and this broke our RTL.
Please see the linked fix proposal.
The text was updated successfully, but these errors were encountered: