Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

inconsistent handling of css case #86

Closed
jdchmiel opened this issue Apr 15, 2014 · 2 comments
Closed

inconsistent handling of css case #86

jdchmiel opened this issue Apr 15, 2014 · 2 comments

Comments

@jdchmiel
Copy link

Unit test:
emogrifyLowercasesAttributeNamesFromStyleAttributes
verifies that inline css in uppercase is translated to lowercase.

Unit test:
emogrifyKeepsAttributeNamesFromCssInOriginalCasing
seems to verify that passed in css does not become lowercase.

I have separately verified that uppercase css in a <style> maintains its uppercase without translation. Is this by design or would you like a pull request to ensure all css is lowercase?

@oliverklee
Copy link
Contributor

Hi, thanks for reporting this. Actually, both should be handled the same way. I'd say, we lowercase them all the time (be it from style attributes or the attached CSS) so we can handle cases where attributes get overwritten. (Of course, we need to cover this case with unit tests as well.)

A pull request would be awesome. ❤️

@jdchmiel
Copy link
Author

Added this to #85 since they overlapped extensively.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants