Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

I_ComponentBuilderFactory and C_Engine::GetGlobalComponentBuilder return type unification #138

Closed
RohacekD opened this issue Mar 29, 2021 · 2 comments · May be fixed by #139
Closed

I_ComponentBuilderFactory and C_Engine::GetGlobalComponentBuilder return type unification #138

RohacekD opened this issue Mar 29, 2021 · 2 comments · May be fixed by #139
Assignees
@RohacekD
Labels
enhancement New feature or request Free to take Nice begining issue Refactor

Comments

@RohacekD
Copy link
Collaborator

Describe the bug
The former named returns unique ptr and later one raw pointer. Both should return the same type. Prefarably unique ptr.

Expected behavior

  • C_EntityManager refactor.
  • C_Engine refactor.
@RohacekD RohacekD added enhancement New feature or request Refactor Free to take Nice begining issue labels Mar 29, 2021
@RohacekD RohacekD self-assigned this Apr 22, 2021
@RohacekD
Copy link
Collaborator Author

This bug is concerned wtih #Audio branch

@RohacekD
Copy link
Collaborator Author

RohacekD commented May 9, 2022

I have moved away from component builders.

@RohacekD RohacekD linked a pull request May 9, 2022 that will close this issue
Basic FMOD integration and gradrigo #139
Open
@github-project-automation github-project-automation bot moved this to Done in Core Aug 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@RohacekD RohacekD

Labels
enhancement New feature or request Free to take Nice begining issue Refactor
Projects
Core
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Basic FMOD integration and gradrigo MySchoolEngine/GLEngine
1 participant
@RohacekD