Skip to content
This repository has been archived by the owner on Sep 8, 2024. It is now read-only.

Improve naming of entity registration arguments #2950

Closed
krisgesling opened this issue Jul 14, 2021 · 0 comments · Fixed by #2963
Closed

Improve naming of entity registration arguments #2950

krisgesling opened this issue Jul 14, 2021 · 0 comments · Fixed by #2963
Labels
help wanted Type: Refactoring and other improvements Improvement of code and documentation that does not alter functionality.

Comments

@krisgesling
Copy link
Contributor

krisgesling commented Jul 14, 2021 •
edited
Loading

Description:
When registering entities with Adapt we use start_concept, end_concept whilst Adapt uses entity_value, entity_type. Start and End don't really reflect what the arguments are (if I understand them correctly). So I'm recommending that we rename them throughout the code base. Docstrings should also be added or updated as needed.

Additional context
Originally raised in this PR
#2877 (review)
@krisgesling krisgesling added Type: Refactoring and other improvements Improvement of code and documentation that does not alter functionality. help wanted labels Jul 14, 2021
@forslund forslund mentioned this issue Aug 2, 2021
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
help wanted Type: Refactoring and other improvements Improvement of code and documentation that does not alter functionality.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update key names in adapt keyword registration message forslund/mycroft-core
1 participant
@krisgesling