Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

What's your name question interferes with other skills #58

Open
adocampo opened this issue Jan 19, 2021 · 1 comment
Open

What's your name question interferes with other skills #58

adocampo opened this issue Jan 19, 2021 · 1 comment

Comments

@adocampo
Copy link
Contributor

Describe the bug
Title says everything. When I ask something with the word "name", it always triggers as it I would have asking the device's name. So it interferes for example with Wolfram Alpha skill, when you ask for "what is Madonna's real name?" it says the device's name instead.
imagen

To Reproduce
Steps to reproduce the behavior:

  1. ask for Madonna's real name
  2. listen the results
  3. say "what name"
  4. listen the results

Expected behavior
when ask for madonna's real name, it should use wolfram alpha skill and answer with the proper name
when ask "what name" it should return some kind of error

Environment (please complete the following information):

  • Device type: Any, tested on mark1 and desktop
  • OS: Mark1's debian and Arch Linux on desktop
  • Mycroft-core version: 20.08
@adocampo adocampo added the bug Something isn't working label Jan 19, 2021
@krisgesling krisgesling added help wanted bug and removed bug Something isn't working labels Jan 19, 2021
@krisgesling
Copy link
Contributor

Thanks for flagging this.

It looks like the intent definition here is too general and will trigger on the two keywords "what" and "name".

This is a good issue for a newer contributor interested in learning about intents and collisions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants