Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix german language issue #81

Open
wants to merge 3 commits into
base: 20.02
Choose a base branch
from
Open

fix german language issue #81

wants to merge 3 commits into from

Conversation

gador
Copy link
Contributor

@gador gador commented Aug 5, 2020

Fixes #80
Also adds two lines to what.time.is.it intent which are very commonly used in German.
(As of now, mycroft will redirect the question of what time it is in German to wolfram alpha, which answers, but doesn't involve this skill)

@krisgesling
Copy link
Contributor

Hey gador, I wanted to make sure you were aware of https://translate.mycroft.ai/

This is where we manage translations of Skills and other strings. The translations from there are then synced back to each of the repo's. So even if we merge this it will get overwritten by the next Translate PR.

Are you able to jump in there and update the relevant entry?

@gador
Copy link
Contributor Author

gador commented Aug 7, 2020

Hi Kris,
yes I am. I updated the relevant sections, but was unable to add the two more german translation lines in
vocab/de-de/what.time.is.it.intent (see commit )
What is the workflow for adding sentences to a translation?

@krisgesling
Copy link
Contributor

Yeah this is one of the limitations of the Pootle interface, it's a direct translation per line of a file, so there's not really capacity to add extra lines.

You could try using a newline character in one of the strings for that file? Perhaps we should try this on the "00__skill_template" first. Then we can see what is output when the PR gets generated against that repo.

@gador
Copy link
Contributor Author

gador commented Aug 11, 2020

@krisgesling ,sounds reasonably. Do you mean a PR with a new empty line in the english vocab file for example here ?
And then heading to https://translate.mycroft.ai and checking whether I can add a german translation?

@krisgesling
Copy link
Contributor

No I was wondering if there was a way we could add new lines in Translate, without having to create PR's in the original Skill.

So I'm curious whether for an input phrase like "count", can we provide a multi-line translation - like so:
https://translate.mycroft.ai/de/mycroft-skills/translate/00__skill_template-de.po
(Is this translation correct?)

It throws an error in the Translation interface, but it may export to the Skill correctly.

@gador
Copy link
Contributor Author

gador commented Aug 26, 2020

hi @krisgesling ,
actually it would be correct to use the imerative form: "zähl".
Couldn't you also use "|" with parenthesis to include another sentence?
For example here I used the following:

current time

translates to:

((aktuelle (uhrzeit | zeit))|wie spät ist es)

meaning, you could either say "aktuelle uhrzeit", "aktuelle zeit", or what everyone else says: "wie spät ist es"
What do you say?

Two maybe unrelated questions:

  • Is there a way to automatically set everything to lowercase in the translation? Since the intent files don't parse with uppercase words and many German translations have (grammatically correct) uppercase words which need to be manually fixed..

  • Can someone force a PR to include the updated languages? Right now I fix the language in the translate.mycroft.ai interface and manually on my picroft, but get the obvious error on updates that I have uncommitted changes in my skill repo..
    (For example the stop skill has a german translation "Stop". But the STT engine translates a spoken stop to the German word "Stopp". So the stop skill doesn't recognize stop. I fixed it in the translate.mycroft.ai interface, but have no idea how that translation gets included in the skill..)

Otherwise we could try with a newline character in translate.mycroft.ai but I don't know how to include the new translation in the repo, even for testing..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

german language issue
2 participants