Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sane behavior with pin placing mods (locator, AutoMapPins) #21

Open
Mydayyy opened this issue Mar 8, 2021 · 6 comments
Open

Sane behavior with pin placing mods (locator, AutoMapPins) #21

Mydayyy opened this issue Mar 8, 2021 · 6 comments

Comments

@Mydayyy
Copy link
Owner

Mydayyy commented Mar 8, 2021

No description provided.

@Mydayyy Mydayyy modified the milestones: 1.3.1, 1.3.0 Mar 9, 2021
@JTF195
Copy link

JTF195 commented Mar 12, 2021

WeylandMod is another one to take a look at.
It does most of the same things (and a ton of other things that are way out of scope)

There should be no reason for someone to use both, but it may be worth ensuring that nothing breaks if they do

@Mydayyy
Copy link
Owner Author

Mydayyy commented Mar 12, 2021

I just had a look at Locator and AutoMapPins and I think the current behavior is already pretty sane in my opinion.

  1. AutoMapPins only places temporary pins, so SSM ignores them completely. Those arent synced when using commands nor are they send to the server when placed. I think that's pretty sane given that the Mod places a lot of pins and even decided itself that those pins are only temporary (not saved)

  2. Locator: Places persistent pins. Currently SSM will not sync "live"-sync pincs to the server as they are placed but only when running the pinsync command. I think thats pretty sane too because that gives everyone the choice if they want that many pins on their map and install Locator themselves or just opt out and not install that Plugin

  3. Didn't look at WeylandMod yet, but it should behave the same as Locator

Love hearing other opinions here

Cheers
Mydayyy

@JTF195
Copy link

JTF195 commented Mar 16, 2021

I think it might be worthwhile to make it configurable, if possible.

Indeed, not everyone wants their map filled with pins, but there isn't really anything stopping permitted users from just manually syncing their pins every time the mod adds more. There might as well be an option to automate that process and leave it up to the users to sanely configure the mods in question.

For example, on my server, we always pin caves and crypts, so it would be beneficial if we could configure Locator to pin those straight to the server automatically.

Aside from just configuring the other mods sanely, what about adding client-side filters?

Let users decide which pins they want to see:

  • Pins placed manually
  • Pins synced manually
  • Pins placed automatically by mods (and maybe even filter which mod placed them?)

Several other mods have popped up recently that support various pin sync features. It might be worth checking them out and stealing a few ideas.

@JTF195
Copy link

JTF195 commented Mar 16, 2021

Here's a more 'pipe dream' idea

What if there were a mechanism to allow other mods to pin to the server based on their own configurable options?

For example, what if Locator could be configured to pin caves and crypts to the server, but only pin pickables and ores client-side?

@Mydayyy
Copy link
Owner Author

Mydayyy commented Mar 17, 2021

I think it might be worthwhile to make it configurable, if possible.

I gave it a bit of thought and I think its only configurable to a certain extend. I would be able to track Pins that are placed without user interaction, but I wouldn't know who placed them. So while you could for example set "track automatically placed pins", that would track every pin that is placed, no matter the mod. I would not be able to detect that a pin is placed by locator.

I'll give it some more thought and take a look at that on the weekend

Here's a more 'pipe dream' idea
What if there were a mechanism to allow other mods to pin to the server based on their own configurable options?
For example, what if Locator could be configured to pin caves and crypts to the server, but only pin pickables and ores client-side?

That would be amazing, it would require to make my functions available for other mods to call.
And most importantly other mod developers would need to implement that, which is probably the hardest part.

Cheers
Mydayyy

@Mydayyy Mydayyy removed this from the 1.3.0 milestone Apr 9, 2021
@git-you-cat
Copy link

The hotkey function is swell but it would be great to have an optional autosync feature that includes the ignore local dupes command.

Definitely go roaming around with friends quite a bit and we want to pin an ore spot to come back to and there is a lot of "did someone pin that?"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants