Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Properly trigger suggest (textDocument/complete) and parameterHints (textDocument/) in suitable timings #293

Closed
Myriad-Dreamin opened this issue May 15, 2024 · 1 comment · Fixed by #874
Labels
completion Features about LSP completion enhancement New feature or request

Comments

@Myriad-Dreamin
Copy link
Owner

Describe the bug

The python lsps are exemplary.

I need an approach to invoke editor.action.triggerSuggest and editor.action.triggerParameterHints at the same time, after a field completion, but I don't find a way other than letting client provide an extra commands,

// https://github.com/microsoft/language-server-protocol/issues/1117
. This is because microsoft/language-server-protocol#1117.
I looked at rust-analyzer, and find that the parameter hints (signature help) keeps until exiting a function autocompletion. That is, if tinymist does same thing as ra, when I type text, tinymist will complete text(${content-arg}, fill: ${fill-arg}, stroke: ${stroke-arg}, ..), and I will continue finishing my function call for tabs and go to ${content-arg}, ${fill-arg}, and so on. however it is probably not what we would like to have, as we usually write text(fill: blue) and then add a content arguments by []. I may look at python lsps then.

Package/Software version:

tinymist extension version: v0.11.8.

@Myriad-Dreamin
Copy link
Owner Author

link #257

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
completion Features about LSP completion enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant