-
Notifications
You must be signed in to change notification settings - Fork 11.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make bounded_visitor default bound configurable #17310
Comments
This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 7 days. |
Resolved by #18175 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Steps to Reproduce Issue
Upon trying to perform a
sui_tryMultiGetPastObjects
on checkpoint 32260640, we get the following error:I'm not sure exactly which object right now since our logs don't mention it.
However, upon digging through the code, it looks like a potential fix for this is to just allow the bounded_visitor default bound (or deserialization code path) to be configurable.
Here are some more details from tracing the error in the SUI codebase:
This is the error:
The error is returned in
bounded_visitor.rs:debit()
:sui/crates/sui-types/src/object/bounded_visitor.rs
Line 72 in 0d2d137
debit()
is called while deserializing the struct.The struct deserialization path just uses
Self::default()
self.bound
defaults toconst MAX_BOUND: usize = 1024 * 1024;
Since we are running our own SUI node, a quick fix for this would be to make the default for self.bound configurable rather than using a hardcoded const, and then we can re-deploy the updated version with the appropriate configuration increasing the default bound.
Expected Result
Expect to be able to successfully retrieve the object history when using
sui_tryMultiGetPastObjects
.Actual Result
SUI RPC node error in the description above.
System Information
mysten/sui-node:mainnet-v1.23.1
)The text was updated successfully, but these errors were encountered: