Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[wallet] Ledger 1.3 firmware broke sui wallet #20483

Open
poelzi opened this issue Dec 2, 2024 · 8 comments
Open

[wallet] Ledger 1.3 firmware broke sui wallet #20483

poelzi opened this issue Dec 2, 2024 · 8 comments
Assignees

Comments

@poelzi
Copy link

poelzi commented Dec 2, 2024

Steps to Reproduce Issue

  1. Update Ledger Nano S Firmware to 1.3
  2. Sign transaction

Tested same PC with backup stick, firmware 1.1.2 works. Problem started after update

Expected Result

Normal balance changes

Actual Result

Balance changes are empty

System Information

  • OS: NixOS 2024.4
@williamrobertson13
Copy link
Contributor

Hey @poelzi! I would recommend upgrading to the latest firmware (should be 2.1.0 according to https://support.ledger.com/article/360010446000-zd) and trying again. I'd also make sure you have your seed phrase for your device backed up just in case when upgrading firmware versions.

@poelzi
Copy link
Author

poelzi commented Dec 2, 2024

I meant Ledger Nano S Plus. The firmware 1.3 came out in the last days. The older version 1.2.1 worked without problems

@williamrobertson13
Copy link
Contributor

Ah gotchya. I reported this to Ledger + the folks who work on our Ledger app, I'll provide an update as soon as I have one.

@vforgeoux-ledger
Copy link

Hey @poelzi , can you please be more precise on the issue ? Reading "Balance changes are empty" I understand that the signature fails so the transaction isn't broadcasted?

@poelzi
Copy link
Author

poelzi commented Dec 4, 2024

@vforgeoux-ledger I tried to delete a liquidity pool on cetus. When you start a transaction, you see the balance changes on top of the transaction window. If anything is wrong, this list is empty. For example, the ledger is locked or not in the Sui app.
With 1.3, this list is empty. Then I pulled out my backup stick which is still the old firmware and the window was ok.
It worked before I updated. Tried to use another network and could not find the app, so I updated the firmware.
I of course, power-cycled the stick, restarted browser etc.
So, my guess is, that something changed - either API between Sui Leder App and firmware or communication browser app and ledger.

@poelzi
Copy link
Author

poelzi commented Dec 4, 2024

@vforgeoux-ledger
Copy link

Hey @poelzi , did you try to reconnect your device? On my side I've tried to add a new Ledger account on SUI wallet to make the connection again. Then I was able to sign smart contract interactions on Cetus, that were not correctly triggered before.

Tested with Nano S+ OS 1.3.0 and SUI app version 0.2.1

@poelzi
Copy link
Author

poelzi commented Dec 10, 2024

It seems that removing and re-adding the account fixed the problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants