Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Party invite is case-insensitive, other actions are #282

Closed
horgeon opened this issue Jul 3, 2017 · 1 comment
Closed

Party invite is case-insensitive, other actions are #282

horgeon opened this issue Jul 3, 2017 · 1 comment
Milestone

Comments

@horgeon
Copy link

horgeon commented Jul 3, 2017

Using MinigamesAPI v1 compiled as of ae27f78, party actions are case-sensitive except invitation.

It causes issues where players seems to be invited but can not join.

It is likely caused by Bukkit.getPlayer which is case-insensitive.

One solution may be to get the target player in partyInvite method from CommandHandler.java after the validation and uses his name directly (getName()) instead of the first command argument, so it uses the exact player name.

I hope you will consider fixing this.

@mepeisen mepeisen added this to the 1.14.18 milestone Jul 16, 2017
@mepeisen
Copy link
Collaborator

Fixed by complete refactoring. Party system uses UUIDs now.

Latest snapshot can be found at http://www.minigameslib.de/downloads_en.php
It will be build within the next minutes.

closed If this does not help please respond. I will reopen the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants