-
Notifications
You must be signed in to change notification settings - Fork 293
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add optional station_parking rule to geofencing_zones.json #349
Conversation
Hey! can I ask for the status of this topic? We (TIER) have the same problems mentioned in #332, this would solve this definitely. Is this planned for the next GBFS release? |
I'll add it to MobilityData's Q4 roadmap. We're planning on another set of batched votes this quarter once some of the open discussions settle into a community consensus. But before we open a vote for this, it would be great if we could hear from any GBFS consumers who would support this addition - we'll need it for the vote! |
I hereby call a vote on this proposal. Voting will be open for 10 full calendar days until 11:59PM UTC on December 10th, 2021. Please vote for or against the proposal, and include the organization for which you are voting in your comment. Please note if you can commit to implementing the proposal. |
+1 from Transit |
+1 from TIER |
@@ -1009,6 +1009,7 @@ Field Name | REQUIRED | Type | Defines | |||
   \- `ride_allowed` | Conditionally REQUIRED | Boolean | REQUIRED if `rules` array is defined. Is the undocked (“free bike”) ride allowed to start and end in this zone? <br /><br /> `true` - Undocked (“free bike”) ride can start and end in this zone. <br /> `false` - Undocked (“free bike”) ride cannot start and end in this zone. | |||
   \- `ride_through_allowed` | Conditionally REQUIRED | Boolean | REQUIRED if `rules` array is defined. Is the ride allowed to travel through this zone? <br /><br /> `true` - Ride can travel through this zone. <br /> `false` - Ride cannot travel through this zone. | |||
   \- `maximum_speed_kph` | OPTIONAL | Non-negative Integer | What is the maximum speed allowed, in kilometers per hour? <br /><br /> If there is no maximum speed to observe, this can be omitted. | |||
   \- `station_parking` | OPTIONAL | Boolean | Vehicle MUST be parked at stations defined in station_information.json within this geofence zone? <br /><br />`true` - MUST only be parked at stations. <br /> `false` - MAY be parked outside of stations. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This usage of capitalized keywords "MUST" and "MAY" seems non-standard. These capitalized keywords are used for describing the spec, and not for the semantics of the data itself.
I suggest this:
Can the vehicle only be parked at stations defined in station_information.json within this geofence zone? true
- Can only be parked at stations.
false
- May be parked outside of stations.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Entur supports this proposal |
Voting on this PR closes in 2 calendar days. Please vote for or against the proposal, and include the organization for which you are voting in your comment. Please note if you can commit to implementing the proposal. |
This vote has now closed, and it passes! Votes in favor: There were no votes against. We will tag and merge this into v2.3-RC2 in the coming weeks. |
What problem does your proposal solve? Please begin with the relevant issue number. If there is no existing issue, please also describe alternative solutions you have considered.
This PR follows up on the suggestions made by @mplsmitch on #332 (specifically here).
It is also worth noting that for #332 to be fully resolved, #329 is also needed.
What is the proposal?
From #332 (comment):
Is this a breaking change?
Which files are affected by this change?
geofencing_zones.json