Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't load mesh for invalid stream #7

Open
parkerabercrombie opened this issue Oct 30, 2019 · 0 comments
Open

Don't load mesh for invalid stream #7

parkerabercrombie opened this issue Oct 30, 2019 · 0 comments

Comments

@parkerabercrombie
Copy link

If a B3DM file does not match expected format, the loader should not try to load it. We found this problem because out application did not correctly identify an a network error, and fed and xml document into the B3DM loader, which resulted in an out of memory exception trying to create a mesh out of garbage data.

The loader checks for valid data, but only logs a warning and continues: https://github.com/NASA-AMMOS/Unity3DTiles/blob/master/Assets/Unity3DTiles/B3DMLoader.cs#L59
I think desired behavior is to bail out on loading the tile if the data is not valid B3DM.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant