Adjust datetime filter for STAC search

[ividito]

When filtering a STAC /search by datetime, the method currently being used will not always return desired results (veda-backend/#170). Instead of using a filter to refine /search requests, we should use the datetime parameter, which will find overlapping data instead of data where the start_datetime falls within the search range.

For example, the following request:

curl --request POST \
  --url https://staging-stac.delta-backend.com/search \
  --header 'content-type: application/json' \
  --data '{"filter-lang":"cql2-json","filter":{"op":"and","args":[{"op":">=","args":[{"property":"datetime"},"2085-02-14T00:00:00.000Z"]},{"op":"<=","args":[{"property":"datetime"},"2085-02-14T23:59:59.999Z"]},{"op":"eq","args":[{"property":"collection"},"CMIP245-winter-median-ta"]}]},"limit":500}'

Should be converted to:

curl --request POST \
  --url https://staging-stac.delta-backend.com/search \
  --header 'content-type: application/json' \
  --data '{"filter-lang":"cql2-json","datetime": "2085-02-14T00:00:00Z/2085-02-14T23:59:59Z","filter":{"op":"and","args":[{"op":"eq","args":[{"property":"collection"},"CMIP245-winter-median-ta"]}]},"limit":500}'

This change should also avoid the need to merge veda-config/#240

[anayeaye]

@ividito it just now occurred to me to check if this collection used a nominal datetime or a time range (start/end). It looks like a range was used for the item datetime properties instead of a single nominal datetime. As in:

https://staging-stac.delta-backend.com/collections/CMIP245-winter-median-ta/items/CMIP6ensembleMedian_diff_winter_tas_ssp245_20850214.cog
Item id CMIP6ensembleMedian_diff_winter_tas_ssp245_20850214.cog
start_datetime 2085-01-01T00:00:00+00:00
end_datetime 2085-03-31T12:00:00+00:00
datetime not defined

So in this case pgstac is behaving as expected for the filter search. If a nominal datetime of 2085-02-14T00:00:00.000Z had been used for this item, the cql2-json filter would catch it. For the current items the filter needs to use the start and end datetime properties. Restructuring the request for this individual collection to use the base stac-api datetime parameter is a good solution.

[j08lue]

Looks like the old method is still being used

veda-ui/app/scripts/components/common/mapbox/layers/utils.ts

Lines 344 to 362 in 41b77fb

	export function getFilterPayload(date: Date, collection: string) {
	return {
	op: 'and',
	args: [
	{
	op: '>=',
	args: [{ property: 'datetime' }, userTzDate2utcString(startOfDay(date))]
	},
	{
	op: '<=',
	args: [{ property: 'datetime' }, userTzDate2utcString(endOfDay(date))]
	},
	{
	op: 'eq',
	args: [{ property: 'collection' }, collection]
	}
	]
	};
	}