Skip to content

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

comment for future redesign of the matlab diagnostics. #319

Closed
hkershaw-brown opened this issue Jan 6, 2022 · 0 comments
Closed

comment for future redesign of the matlab diagnostics. #319

hkershaw-brown opened this issue Jan 6, 2022 · 0 comments
Labels
pmp possible Marlee project

Comments

@hkershaw-brown
Copy link
Member

this is a comment for future redesign of the matlab diagnostics. there's something not right about how this was implemented if adding a new model to the diagnostics requires every .m file to have the case statement updated with the name of the model.

for example, the pinfo structure could define categories of models (e.g. 1d, 3d, etc), in addition to the model name. to add a new model that is similar to an existing one, you set the appropriate category string. then these files have a case statement on pinfo.category. as long as you're not adding a model that needs different code, you wouldn't have to change the .m files at all.

Originally posted by @nancycollins in #262 (comment)

@hkershaw-brown hkershaw-brown added the pmp possible Marlee project label Apr 15, 2022
@NCAR NCAR locked and limited conversation to collaborators May 24, 2022
@hkershaw-brown hkershaw-brown converted this issue into discussion #357 May 24, 2022

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

Labels
pmp possible Marlee project
Projects
None yet
Development

No branches or pull requests

1 participant