-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BOV reader semi-support time steps #2791
Comments
Visit's BOV specification doesn't mention specifying multiple time steps like this. IMO, this is an enhancement. BOV Specification: section 3, page 9 |
@shaomeng are you sure the file you created (bug3.bov) is how time-varying data sets are supported? My interpretation of VisIt's documentation is that you can only have one set of keyword-value pairs per file. I.e. You need a single file per time step or per variable. I could be wrong, however. |
@clyne VAPOR shows 2 time steps available with the bov file in question, and a user is able to switch between these 2 time steps. It's OK to not show 2 time steps if you don't support 2 time steps. Re VisIt comparison: I feel we're in a state where when VAPOR behaves differently from VisIt and its documentation, it's considered a VAPOR uniqueness. When VAPOR exhibits a bug (or bad behavior in general) and VisIt behaves the same, it's considered "see, VisIt does the same." This isn't a good situation to be in. |
Agreed that it should not show two time steps. I think a reasonable behavior for repeating the same keyword multiple times is to simply accept the last value found. |
To reproduce:
/glade/p/cisl/vast/vapor/Bugs/BOV_Bugs/bug3.bov
The text was updated successfully, but these errors were encountered: