Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't compiler lib/osgl with OpenMP enabled on OSX #3179

Closed
clyne opened this issue Aug 12, 2022 · 2 comments · Fixed by #3110
Closed

Can't compiler lib/osgl with OpenMP enabled on OSX #3179

clyne opened this issue Aug 12, 2022 · 2 comments · Fixed by #3110
Assignees
Milestone

Comments

@clyne
Copy link
Collaborator

clyne commented Aug 12, 2022

Compiling with OpenMP support on OSX requires using the vanilla clang compiler (not Apple's bundled bastardization of clang). Compilation is failing as shown below:


[ 10%] Building C object lib/osgl/CMakeFiles/osgl.dir/glad/src/egl.c.o
In file included from /Users/clyne/src/vapor/lib/osgl/GLContextProviderMacOS.mm:2:
In file included from /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX12.1.sdk/System/Library/Frameworks/AppKit.framework/Headers/NSOpenGL.h:9:
In file included from /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX12.1.sdk/System/Library/Frameworks/Foundation.framework/Headers/Foundation.h:12:
/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX12.1.sdk/System/Library/Frameworks/Foundation.framework/Headers/NSBundle.h:91:143: error: function does not return NSString
- (NSAttributedString *)localizedAttributedStringForKey:(NSString *)key value:(nullable NSString *)value table:(nullable NSString *)tableName NS_FORMAT_ARGUMENT(1) NS_REFINED_FOR_SWIFT API_AVAILABLE(macos(12.0), ios(15.0), watchos(8.0), tvos(15.0));

cisl-benona[611] clang --version
clang version 12.0.1
Target: x86_64-apple-darwin20.6.0
Thread model: posix
InstalledDir: /opt/local/libexec/llvm-12/bin

I believe that this issue is related to #3158

Clearly we have to fix this to release. Giving the issue a milestone and assigning to @StasJ

@clyne clyne added this to the 3_7_0_Release milestone Aug 12, 2022
@sgpearse
Copy link
Collaborator

@clyne I'm currently in the middle of debugging this for #3158. I'm going to assign to myself and if I hit a brick wall I'll include @stas.

@clyne
Copy link
Collaborator Author

clyne commented Aug 17, 2022

This is fixed after upgrading clang compiler to clang-13. Closing.

@clyne clyne closed this as completed Aug 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants