Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conditionally allocated variables for Ferrier Aligo microphysics must have assumed-size #357

Closed
climbfuji opened this issue Nov 22, 2019 · 0 comments · Fixed by #611
Closed

Comments

@climbfuji
Copy link
Collaborator

I have not checked this, but noting it so that it does not get forgotten:

All conditionally-allocated arrays must have an assumed-size declaration in subroutines using them (unless that particular subroutine is only ever called when the array is allocated; but even in this case assumed-size arrays are better, because they allow bounds checking).

For Ferrier-Aligo, there are many variables that are conditionally allocated. Someone needs to check if these get used in routines that can get called without the arrays being allocated, and if so, convert explicit dimensions in variable declarations to assumed-size dimensions:

real(kind_phys), intent(in) :: train(:,:)

instead of

real(kind_phys), intent(in) :: train(1:im,1:km)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant