Stop statements in physics routines

[michalakes]

Description

There are 58 instances of STOP statements in 22 source files in the physics repository. These are violations of the CCPP coding standards (https://ccpp-techdoc.readthedocs.io/en/latest/CompliantPhysicsParams.html?highlight=stop#coding-rules) and they cause jobs to hang on some systems when one or a few MPI tasks stop leaving the rest of the MPI tasks and the job sitting in a run-state consuming resources in the batch queue.

Steps to Reproduce

1. Check out commit 7e35351 (HEAD -> main, origin/release/public-v6, origin/main, origin/HEAD)
2. cd into ccpp-physics/physics directory
3. grep -i '^ *stop' *.f *.F90 *.f90

Additional Context

N.A.

Output

commit 7e3535134272169e5ae4690aa47e4e9325aefc64 (HEAD -> main, origin/release/public-v6, origin/main, origin/HEAD)
Merge: 860245ca b76a1ef8
Author: Grant Firl [grant.firl@noaa.gov](mailto:grant.firl@noaa.gov)
Date:   Fri Apr 22 12:02:36 2022 -0400

narwhal:/p/home/michalak/neptune_refactor/ccpp-physics/physics 1010 > grep -i '^ *stop' *.f *.F90 *.f90
radiation_aerosols.f:            stop
radiation_aerosols.f:        stop
radiation_aerosols.f:        stop
radiation_aerosols.f:        stop
radiation_aerosols.f:        stop
radiation_aerosols.f:            stop
radiation_aerosols.f:              stop
radiation_aerosols.f:              stop
radiation_aerosols.f:              stop
radiation_aerosols.f:              stop
radiation_aerosols.f:            stop
radiation_aerosols.f:        stop 3000
radiation_aerosols.f:         stop 1220
radiation_aerosols.f:          stop 1222
radiation_astronomy.f:            stop
radiation_clouds.f:        stop
radiation_clouds.f:            stop
radiation_gases.f:          stop
radiation_gases.f:            stop
radiation_gases.f:              stop
radiation_gases.f:            stop
radiation_gases.f:              stop
radiation_gases.f:          stop
radiation_gases.f:            stop
radiation_gases.f:              stop
set_soilveg.f:            STOP 222
set_soilveg.f:            STOP 222
set_soilveg.f:            STOP 222
sfc_diff.f:              stop
sflx.f:        stop 333
sflx.f:        stop 333
sflx.f:        stop 333
sflx.f:        stop 333
cires_ugwpv1_oro.F90:          stop
cu_gf_deep.F90:      stop "problems with finding the 2nd derivative"
gcycle.F90:        stop
GFS_debug.F90:             stop
GFS_rrtmg_setup.F90:         stop 7777
GFS_rrtmg_setup.F90:          stop
GFS_rrtmg_setup.F90:          stop
m_micro.F90:      stop
module_gfdl_cloud_microphys.F90:        stop
module_mp_thompson.F90:               stop
module_mp_thompson.F90:               stop
module_SF_JSFC.F90:              stop
module_sf_mynn.F90:              stop
module_sf_ruclsm.F90:          stop
radlw_main.F90:        stop
radlw_main.F90:          stop
radlw_main.F90:        stop
radlw_main.F90:                stop 'INFLAG = 1 OPTION NOT AVAILABLE WITH MCICA'
radsw_main.F90:        stop
radsw_main.F90:          stop
radsw_main.F90:        stop
set_soilveg_ruc.F90:            STOP 222
set_soilveg_ruc.F90:            STOP 222
set_soilveg_ruc.F90:            STOP 222
module_sf_exchcoef.f90:             stop

narwhal:/p/home/michalak/neptune_refactor/ccpp-physics/physics 1011 > grep -i '^ *stop' *.f *.F90 *.f90 | wc
     58     144    2103

narwhal:/p/home/michalak/neptune_refactor/ccpp-physics/physics 1012 > grep -i -l '^ *stop' *.f *.F90 *.f90 | wc
     22      22     392

[dustinswales]

@michalakes These have been removed as part #956