Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[💡]: The running speed of delta_pressure #619

Open
cccccoldrun opened this issue May 16, 2024 · 2 comments
Open

[💡]: The running speed of delta_pressure #619

cccccoldrun opened this issue May 16, 2024 · 2 comments
Assignees
Labels
scalability and performance Related to scalability, performance, or benchmarking support Support request opened by outside user/collaborator

Comments

@cccccoldrun
Copy link

Describe the functionality you are requesting, linking any relevant usage or previous implementations in the python ecosystem or otherwise.

Hello developers, here I am again, after you guys fixed the delta_pressure bug, it seems that its speed of operation has dropped drastically. I have a 200200300 (time,lat,lon) array about the pressure, in NCL it can be calculated in about 1 minute, while in Python this seems to take a long time.

Is this a request for functionality that was previously in NCL?

Yes

Additional context

No response

@cccccoldrun cccccoldrun added feature a new feature that is going to be developed support Support request opened by outside user/collaborator triage Needs triage labels May 16, 2024
@kafitzgerald
Copy link
Contributor

Thanks for the the report!

Just to clarify, was this slow down from NCL to GeoCAT or GeoCAT (before the fix) to GeoCAT (after the fix) or both? Regardless, we can take a look, but this would be useful context if you have it.

@kafitzgerald kafitzgerald added scalability and performance Related to scalability, performance, or benchmarking and removed feature a new feature that is going to be developed triage Needs triage labels May 16, 2024
@kafitzgerald kafitzgerald self-assigned this May 16, 2024
@cccccoldrun
Copy link
Author

Hello:
After testing, the GeoCAT (after the fix) is slower than NCL, the results of the GeoCAT (before the fix) were not tested, and my test is as follows:
NCL code and result:
屏幕截图 2024-05-17 094003
屏幕截图 2024-05-17 093833
NCL finished this test using 3s.

Python code and result:
屏幕截图 2024-05-17 105719
while Python spends 524s, if the pressure level is incremental, it will spend more time

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
scalability and performance Related to scalability, performance, or benchmarking support Support request opened by outside user/collaborator
Projects
None yet
Development

No branches or pull requests

2 participants