Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add unit test for Data.equals method #251

Closed
sadielbartholomew opened this issue Aug 27, 2021 · 1 comment
Closed

Add unit test for Data.equals method #251

sadielbartholomew opened this issue Aug 27, 2021 · 1 comment
Assignees
@sadielbartholomew
Labels
dask Relating to the use of Dask

Comments

@sadielbartholomew
Copy link
Member

Particularly to confirm the validity of the migration from LAMA to Dask in #182, we should add a new test method to explicitly test the Data.equals method as it does not seem to be unit tested yet, despite the other tests relying on it for many test assertions.

This would be a test akin to test_Field_equals and similar test methods as existing for CellMethod and CoordinateReference currently, so the name test_Data_equals would be consistent with those.
@sadielbartholomew sadielbartholomew self-assigned this Aug 27, 2021
@sadielbartholomew sadielbartholomew mentioned this issue Aug 27, 2021
Merged
@davidhassell davidhassell added the dask Relating to the use of Dask label Oct 5, 2021
@sadielbartholomew
Copy link
Member Author

Not sure why this didn't get closed automatically when #254 was merged...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sadielbartholomew sadielbartholomew

Labels
dask Relating to the use of Dask
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@davidhassell @sadielbartholomew