Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LAMA to Dask: replace func usage with Dask built-ins #302

Closed
8 tasks done
sadielbartholomew opened this issue Jan 26, 2022 · 1 comment
Closed
8 tasks done

LAMA to Dask: replace func usage with Dask built-ins #302

sadielbartholomew opened this issue Jan 26, 2022 · 1 comment
Assignees
Labels
dask Relating to the use of Dask

Comments

@sadielbartholomew
Copy link
Member

sadielbartholomew commented Jan 26, 2022

To do the follow-up work summarised under the heading 'Context and plan/proposal for follow-on work' in #300 (comment), i.e:

... such methods are more efficiently daskified by conversion to using the existing Dask built-in equivalents instead of calling func this way.

So the plan is to use follow-on PRs to convert from use of func to the appropriate built-in in each method. It turns out there are Dask built-ins for every one listed above available for us to use directly.

Methods to convert

  • the eight trigonometric and hyperbolic methods and their inverses which don't have restricted domains (all except arccos, arcsin, arctanh and arccosh);
  • ceil;
  • exp;
  • floor;
  • rint;
  • round;
  • trunc;
  • log.
@sadielbartholomew
Copy link
Member Author

Closed by #308 and #309.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dask Relating to the use of Dask
Projects
None yet
Development

No branches or pull requests

1 participant