Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Relocate the call to _customize_read_vars() in NetCDFRead.read #233

Closed
davidhassell opened this issue Dec 6, 2022 · 0 comments · Fixed by #234
Closed

Relocate the call to _customize_read_vars() in NetCDFRead.read #233

davidhassell opened this issue Dec 6, 2022 · 0 comments · Fixed by #234
Labels
enhancement New feature or request netCDF read Relating to reading netCDF datasets
Milestone
1.10.0.2

Comments

@davidhassell
Copy link
Contributor

davidhassell commented Dec 6, 2022 •
edited
Loading

Currently, the self._customize_read_vars() call in NetCDFRead.read occurs after the parsing of list, DSG, and geometry variables. This means that custom read vars can't be applied to those features. The _customize_read_vars call should come before these features are parsed, but still after the basic parsing of the file.

PR to follow.
@davidhassell davidhassell added the enhancement New feature or request label Dec 6, 2022
@davidhassell davidhassell added this to the Next release milestone Dec 6, 2022
@davidhassell davidhassell changed the title Relocate the _customize_read_vars() in NetCDFRead.read Relocate the call to _customize_read_vars() in NetCDFRead.read Dec 6, 2022
@davidhassell davidhassell mentioned this issue Dec 6, 2022
Merged
@davidhassell davidhassell added the netCDF read Relating to reading netCDF datasets label Nov 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request netCDF read Relating to reading netCDF datasets
Projects
None yet
Milestone
1.10.0.2
Development

Successfully merging a pull request may close this issue.

Relocate the call to NetCDFRead._customize_read_vars() davidhassell/cfdm
1 participant
@davidhassell