Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiple Inferred "Super" Paths #718

Closed
sstemann opened this issue Feb 5, 2024 · 10 comments
Closed

Multiple Inferred "Super" Paths #718

sstemann opened this issue Feb 5, 2024 · 10 comments
Labels
Fugu (Sprint 4) - due July 19 in CI This ticket will be fixed in CI by the end of Fugu/Sprint 4 (July 19)

Comments

@sstemann
Copy link

sstemann commented Feb 5, 2024

There's one inferred edge in the graph view and three inferred "super" paths

image

The middle path says its inferred from manual curation within BTE:

image

The last path seems to have the specified predicate qualifiers while the first two do not:
image

Mostly though, its just a lot of noise - I dont know if this is a UI, merge, or ARA issue

What chemicals may upregulate TFPI

https://ui.test.transltr.io/main/results?l=TFPI%20(Human)&i=NCBIGene:7035&t=1&r=0&q=72ec18aa-caee-4e39-8929-19c7cf70e718

@dnsmith124
Copy link
Collaborator

@gprice1129 can you take a look at this?

@mbrush
Copy link

mbrush commented Feb 6, 2024

Wanted to note the specific issues I see in this example (some may overlap with what sarah pointed out):

  1. The second inferred result has a dashed arrow implying it is inferred, but also a 'curated' icon on the affects predicate. Clicking the predicate reveals BTE to be the only source - suggesting this is indeed an ARA-predicted/inferred result. Seems like there shouldn’t be a 'curated' icon on this edge, or inferred edges generally.

image

  1. The second edge in the support path for this second inferred result is 'upregulated' . . . is this
    what the UI parses the 'causes upregulated abundance or activity of' combination of qualifiers into (for purposes of a snappier label)?

image

  1. The third inferred edge shows the predicate 'affects increased activity or abundance of' - instead of 'causes increased activity or abundance of' . . . not sure if the issue is in the underlying data ( e.g. missing a qualified_predicate: causes ) or a mis-parse on the UI end. This is an ARAGORN-inferred edge @cbizon.

image

  1. Finally, the final support path for this third inferred result seems problematic in both hops. The first hop says that a Drug 'causes' a Gene . . . my guess here is that there are qualifiers missing from the underlying data, or that are in the data but not properly parsed into a composed predicate in the UI (e.g. 'causes increased activity of'). The second hop says that a Gene 'has increased activity or abundance caused by' a Gene in the second hop . . . seems like the causal direction at this hop is wrong here to infer a Oxaliplatin 'causes increased activity of abundance of' Gene prediction. Again, this may be an issue for ARAGORN / @cbizon to weigh in on.

image

@gglusman
Copy link

gglusman commented Feb 6, 2024

In point 4, the "drug causes gene" bit sounds like #689.
As for the wrong causal link, I'll point at #468. There are many such wrong reasoning patterns...

@sierra-moxon sierra-moxon added needs review this ticket needs a broad group of people to review and assign next steps because it crosses teams group1 labels Feb 9, 2024
@gprice1129
Copy link
Collaborator

gprice1129 commented Feb 13, 2024

For @sstemann post:

  1. The graph does not handle the new inferred/lookup paradigm very well yet. My guess is that multiple inferred edges are laying on top of each other on the graph so it is impossible to distinguish them. Is that right @dnsmith124?
  2. The BTE/curated problem is due to a mislabeling in the infores-catalog v3.6.0
  3. Qualifiers come back inconsistently from ARAs as far as I can tell. Especially for MVP1.

@gprice1129
Copy link
Collaborator

@mbrush

  1. This is a bug caused by BTE having the wrong knowledge level in the infores-catalog v3.6.0
  2. That is right, the UI does some extra work here to make things pretty
  3. This means that the ARA did not send back the qualified predicate causes
  4. The first edge is missing the qualifiers. The directionality shown in the second edge is correct based on the underlying data. This is one of those times where the graph has some connection between the search term and answer, but it does not seem causal... In these cases the path display is probably not he best way to visualize the data.

@dnsmith124
Copy link
Collaborator

@gprice1129 That's correct

@sierra-moxon sierra-moxon removed needs review this ticket needs a broad group of people to review and assign next steps because it crosses teams group1 labels Mar 1, 2024
@sstemann
Copy link
Author

I believe 1. is resolved.

It seems like @mbrush @gprice1129 are saying 3. and 4. are issues with the underlying answer graph - which is coming from ARAGORN @cbizon @uhbrar

https://ui.test.transltr.io/main/results?l=TFPI%20(Human)&i=NCBIGene:7035&t=1&r=0&q=dbcc0ce7-f6fd-4764-9b93-8fd3fc8d582e

image

  1. on the ARAX GUI:
    image

  2. on the ARAX GUI:
    image

New 5. this support graphs - i'm not sure i understand how it supports the result
image

@cbizon
Copy link
Collaborator

cbizon commented Apr 24, 2024

Within ARAGORN, this is being tracked here: ranking-agent/aragorn#234
The original Feedback issue: #744

I think that there's still an open question about whether this qualified_predicate should be sent as part of the query.

@sstemann
Copy link
Author

sstemann commented Aug 9, 2024

i know we have the fully qualified predicate in CI. i think we should plan for this for Guppy, because I think there were issues with the fully qualified and it's not in Fugu yet.

@sstemann sstemann added the Guppy (Sprint 5) - due Aug 23 in CI This ticket will be fixed in CI by the end of Guppy (Sprint 5) (Aug 23) label Aug 9, 2024
@sstemann
Copy link
Author

sstemann commented Sep 3, 2024

upon retesting this is resolved in Fugu

@sstemann sstemann closed this as completed Sep 3, 2024
@sstemann sstemann added Fugu (Sprint 4) - due July 19 in CI This ticket will be fixed in CI by the end of Fugu/Sprint 4 (July 19) and removed Guppy (Sprint 5) - due Aug 23 in CI This ticket will be fixed in CI by the end of Guppy (Sprint 5) (Aug 23) labels Sep 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Fugu (Sprint 4) - due July 19 in CI This ticket will be fixed in CI by the end of Fugu/Sprint 4 (July 19)
Projects
None yet
Development

No branches or pull requests

7 participants